diff options
| author | Mary Ruthven <mruthven@chromium.org> | 2019-04-17 12:18:23 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-04-19 14:45:39 -0700 |
| commit | 6d209022032e02125cc33f10d3218a0cc7f8ae68 (patch) | |
| tree | 58e3f812669ad090c7f4f67c4aa0a47996fb0dda | |
| parent | fe1f0e960aefbaa374ab106aace5ec9ceaaf492e (diff) | |
| download | chrome-ec-6d209022032e02125cc33f10d3218a0cc7f8ae68.tar.gz | |
ccd: make ccd open error more meaningful
Right now if 'ccd open' from the console fails, it pretty much always
fails with "nopwd". This error is pretty meaningless, because you can't
even set the password until you open ccd. This change suggests removing
the battery or sending the open command from the AP in dev mode if ccd
open fails. This error should help people remember their device needs to
be in dev mode and open needs to be sent from the AP.
BUG=b:73170050
BRANCH=cr50
TEST=try 'ccd open' from the console. Verify the error message is
changed.
Change-Id: I32ca72ed00e03e62d73942961137591dc69bc8fa
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1572156
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Reviewed-by: Namyoon Woo <namyoon@chromium.org>
| -rw-r--r-- | common/ccd_config.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/common/ccd_config.c b/common/ccd_config.c index 5b5eb87876..9c37ca41d7 100644 --- a/common/ccd_config.c +++ b/common/ccd_config.c @@ -935,11 +935,10 @@ static enum vendor_cmd_rc ccd_open(struct vendor_cmd_params *p) */ } else { /* - * - Password not set * - Battery is present * - Either not in developer mode or the command came from USB */ - why_denied = "nopwd"; + why_denied = "open from AP in devmode or remove batt"; goto denied; } |