diff options
| author | Tim Wawrzynczak <twawrzynczak@chromium.org> | 2019-04-18 14:39:45 -0600 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-04-19 14:45:28 -0700 |
| commit | 8f0c15d3febd94f270f04c103c916ca59eedcdc2 (patch) | |
| tree | ac9c50d47d13e79779890798bb7ca28551e3f6ac | |
| parent | 5adde977fbd35596b707cee5174ac825b42c4179 (diff) | |
| download | chrome-ec-8f0c15d3febd94f270f04c103c916ca59eedcdc2.tar.gz | |
common/usbc_ppc: Fix potential illegal memory access.
Recent coverity scan indicated a potential illegal memory access in
ppc_enter_low_power_mode(). This patch fixes it.
BUG=none
BRANCH=none
TEST=Compiled
Change-Id: I0df1ca23340cd4466f8e71349b89ca1ab68aadbf
Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1574099
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
| -rw-r--r-- | common/usbc_ppc.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/common/usbc_ppc.c b/common/usbc_ppc.c index 2904c00ded..60a514d0f3 100644 --- a/common/usbc_ppc.c +++ b/common/usbc_ppc.c @@ -187,11 +187,13 @@ int ppc_vbus_sink_enable(int port, int enable) int ppc_enter_low_power_mode(int port) { - const struct ppc_config_t *const ppc = &ppc_chips[port]; + const struct ppc_config_t *ppc; if ((port < 0) || (port >= ppc_cnt)) return EC_ERROR_INVAL; + ppc = &ppc_chips[port]; + if (ppc->drv->enter_low_power_mode) return ppc->drv->enter_low_power_mode(port); else |