diff options
| author | Tom Hughes <tomhughes@chromium.org> | 2019-06-14 09:58:44 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-06-15 02:50:41 +0000 |
| commit | bb9122dbca0b94916535d5c01f8e9ba07424316c (patch) | |
| tree | 817a34bae1afeaab7798d15aec038d21b97f2ae2 | |
| parent | 9c0e1fb1484fbe52bf60ea344e8a8dbd7ae08f5e (diff) | |
| download | chrome-ec-bb9122dbca0b94916535d5c01f8e9ba07424316c.tar.gz | |
util: Enable -Wstrict-prototypes for ftdi.h
The pragma is missing a push before the ignore line, which means as it
was written the warning continued to be disabled.
https://gcc.gnu.org/onlinedocs/gcc/Diagnostic-Pragmas.html
clang catches this bug, but gcc doesn't.
util/ec_uartd.c:26:24: error: pragma diagnostic pop could not pop, no
matching push [-Werror,-Wunknown-pragmas]
^
However, it appears we don't even need to disable this warning anymore
since the compilation succeeds without it.
BRANCH=none
BUG=chromium:931797
TEST=make buildall -j
Change-Id: I81d48a841cb16d54fe0878b218e80d8a1d89e129
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1660020
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
| -rw-r--r-- | util/ec_uartd.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/util/ec_uartd.c b/util/ec_uartd.c index 678932ebee..892c55e06b 100644 --- a/util/ec_uartd.c +++ b/util/ec_uartd.c @@ -21,9 +21,7 @@ #include <errno.h> #include <fcntl.h> -#pragma GCC diagnostic ignored "-Wstrict-prototypes" #include <ftdi.h> -#pragma GCC diagnostic pop #include <getopt.h> #include <limits.h> #include <stdio.h> |