diff options
| author | Craig Hesling <hesling@chromium.org> | 2020-06-02 08:29:52 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-06-04 20:07:48 +0000 |
| commit | 4b75792e64ff071581a4d51caa0c88b26e5da851 (patch) | |
| tree | d5510af551530294aa3973dc63dc2e6502acfc01 | |
| parent | 735d6ac67e404e9636936906b9ec0aa3b0af6ada (diff) | |
| download | chrome-ec-4b75792e64ff071581a4d51caa0c88b26e5da851.tar.gz | |
util/flash_jlink.py: Fix formatting + parsing convention
BRANCH=none
BUG=none
TEST=./util/flash_jlink.py --jlink JLinkExe --ip blah
# Ensure that the blah parameter was passed
Signed-off-by: Craig Hesling <hesling@chromium.org>
Change-Id: Iee38468eb38e91eb3f2b6c19de9c5070f1c0bc5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2226878
Commit-Queue: Tom Hughes <tomhughes@chromium.org>
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
| -rwxr-xr-x | util/flash_jlink.py | 29 |
1 files changed, 15 insertions, 14 deletions
diff --git a/util/flash_jlink.py b/util/flash_jlink.py index ae5a0cf921..00261856a2 100755 --- a/util/flash_jlink.py +++ b/util/flash_jlink.py @@ -34,10 +34,10 @@ DRAGONCLAW_CONFIG = BoardConfig(interface=SWD_INTERFACE, device='STM32F412CG') ICETOWER_CONFIG = BoardConfig(interface=SWD_INTERFACE, device='STM32H743ZI') BOARD_CONFIGS = { - 'dragonclaw': DRAGONCLAW_CONFIG, - 'bloonchipper': DRAGONCLAW_CONFIG, - 'dartmonkey': ICETOWER_CONFIG, - 'icetower': ICETOWER_CONFIG, + 'dragonclaw': DRAGONCLAW_CONFIG, + 'bloonchipper': DRAGONCLAW_CONFIG, + 'dartmonkey': ICETOWER_CONFIG, + 'icetower': ICETOWER_CONFIG, } @@ -50,19 +50,20 @@ def create_jlink_command_file(firmware_file): def flash(jlink_exe, ip, device, interface, cmd_file): cmd = [ - jlink_exe, - '-ip', ip, - '-device', device, - '-if', interface, - '-speed', 'auto', - '-autoconnect', '1', - '-CommandFile', cmd_file + jlink_exe, + '-ip', ip, + '-device', device, + '-if', interface, + '-speed', 'auto', + '-autoconnect', '1', + '-CommandFile', cmd_file ] logging.debug('Running command: "%s"', ' '.join(cmd)) subprocess.run(cmd) -def main(): +def main(argv: list): + parser = argparse.ArgumentParser() default_jlink = './JLink_Linux_V670e_x86_64/JLinkExe' @@ -97,7 +98,7 @@ def main(): default='DEBUG' ) - args = parser.parse_args() + args = parser.parse_args(argv) logging.basicConfig(level=args.log_level) if args.board not in BOARD_CONFIGS: @@ -115,4 +116,4 @@ def main(): if __name__ == '__main__': - sys.exit(main()) + sys.exit(main(sys.argv[1:])) |