diff options
| author | Wai-Hong Tam <waihong@google.com> | 2020-01-27 14:40:11 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-02-01 01:11:00 +0000 |
| commit | 71da3cda2154a29aa919bea21820df963c780831 (patch) | |
| tree | a19ee249cf9425a6d85ba31a18b2b7a693e76170 | |
| parent | 533a9c70dc94ddf4c98d7bf7ad2faf980acf9ec2 (diff) | |
| download | chrome-ec-71da3cda2154a29aa919bea21820df963c780831.tar.gz | |
Trogdor: Rename AP_SUSPEND and add its power signal interrupt
Rename the GPIO from AP_SUSPEND_L to AP_SUSPEND as it is active high.
Add its power signal interrupt for easily checking the change.
Enable the config of the debug command powerindebug.
BRANCH=None
BUG=b:146470739, b:148149387
TEST=Checked the AP_SUSPEND power signal status on EC coonsole.
Change-Id: I4fb5684abb6a3367f5ebc54624f286d8c564d91c
Signed-off-by: Wai-Hong Tam <waihong@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2023279
Commit-Queue: Alexandru M Stan <amstan@chromium.org>
Tested-by: Alexandru M Stan <amstan@chromium.org>
Reviewed-by: Alexandru M Stan <amstan@chromium.org>
| -rw-r--r-- | board/trogdor/board.c | 4 | ||||
| -rw-r--r-- | board/trogdor/board.h | 2 | ||||
| -rw-r--r-- | board/trogdor/gpio.inc | 2 |
3 files changed, 7 insertions, 1 deletions
diff --git a/board/trogdor/board.c b/board/trogdor/board.c index 5e966c75cf..978ac75611 100644 --- a/board/trogdor/board.c +++ b/board/trogdor/board.c @@ -203,6 +203,10 @@ const struct power_signal_info power_signal_list[] = { GPIO_WARM_RESET_L, POWER_SIGNAL_ACTIVE_HIGH, "WARM_RESET_L"}, + [SC7180_AP_SUSPEND] = { + GPIO_AP_SUSPEND, + POWER_SIGNAL_ACTIVE_HIGH, + "AP_SUSPEND"}, }; BUILD_ASSERT(ARRAY_SIZE(power_signal_list) == POWER_SIGNAL_COUNT); diff --git a/board/trogdor/board.h b/board/trogdor/board.h index 0bd76f8936..a576a48747 100644 --- a/board/trogdor/board.h +++ b/board/trogdor/board.h @@ -13,6 +13,7 @@ #define CONFIG_SYSTEM_UNLOCKED /* Allow dangerous commands. */ #define CONFIG_USB_PD_DEBUG_LEVEL 3 #define CONFIG_CMD_AP_RESET_LOG +#define CONFIG_CMD_POWERINDEBUG #define CONFIG_HOSTCMD_AP_RESET /* @@ -200,6 +201,7 @@ enum power_signal { SC7180_PMIC_FAULT_L, SC7180_POWER_GOOD, SC7180_WARM_RESET, + SC7180_AP_SUSPEND, /* Number of power signals */ POWER_SIGNAL_COUNT }; diff --git a/board/trogdor/gpio.inc b/board/trogdor/gpio.inc index 66a7dd99f1..ed717a99bc 100644 --- a/board/trogdor/gpio.inc +++ b/board/trogdor/gpio.inc @@ -29,6 +29,7 @@ GPIO_INT(LID_OPEN_EC, PIN(D, 2), GPIO_INT_BOTH | GPIO_HIB_WAKE_HIGH, lid_i GPIO_INT(AP_RST_L, PIN(C, 1), GPIO_INT_BOTH | GPIO_SEL_1P8V, power_signal_interrupt) /* PMIC to signal AP reset */ GPIO_INT(PS_HOLD, PIN(A, 4), GPIO_INT_BOTH | GPIO_PULL_DOWN | GPIO_SEL_1P8V, power_signal_interrupt) /* Indicate when AP triggers reset/shutdown */ GPIO_INT(PMIC_FAULT_L, PIN(A, 3), GPIO_INT_BOTH | GPIO_SEL_1P8V, power_signal_interrupt) /* Any PMIC fault? */ +GPIO_INT(AP_SUSPEND, PIN(5, 7), GPIO_INT_BOTH | GPIO_SEL_1P8V, power_signal_interrupt) /* Suspend signal from PMIC */ /* * When switch-cap is off, the POWER_GOOD signal is floating. Need a pull-down * to make it low. Overload the interrupt function chipset_warm_reset_interrupt @@ -60,7 +61,6 @@ GPIO(EC_BATT_PRES_ODL, PIN(E, 5), GPIO_INPUT) /* Battery Present */ GPIO(PM845_RESIN_L, PIN(3, 2), GPIO_ODR_HIGH | GPIO_SEL_1P8V) /* PMIC reset trigger */ GPIO(PMIC_KPD_PWR_ODL, PIN(D, 6), GPIO_ODR_HIGH | GPIO_SEL_1P8V) /* PMIC power button */ GPIO(EC_INT_L, PIN(A, 2), GPIO_ODR_HIGH) /* Interrupt line between AP and EC */ -GPIO(AP_SUSPEND_L, PIN(5, 7), GPIO_INPUT) /* Suspend signal from AP/PMIC */ GPIO(AP_RST_REQ, PIN(C, 2), GPIO_INPUT) /* Deprecated AP initiated reset indicator */ /* Power enables */ |