diff options
author | Mary Ruthven <mruthven@chromium.org> | 2020-05-19 03:13:05 +1000 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2020-05-28 02:58:28 +0000 |
commit | 000c22149838ac3ffcb2b6115d5442432c028416 (patch) | |
tree | e10b21a200329af2c2549a99e7050dd808745a06 | |
parent | 40b6f3491e6bdc7c796382ab4948aef11a934700 (diff) | |
download | chrome-ec-000c22149838ac3ffcb2b6115d5442432c028416.tar.gz |
cr50_rma_open: fix version check
BUG=none
BRANCH=none
TEST=script works with a cr50 running 0.6.2
Change-Id: I14cfd8d90bff40843493d22576307421524d3350
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2207571
Reviewed-by: Wai-Hong Tam <waihong@google.com>
(cherry picked from commit be7c49d46cd1e8b94be5ce7b3752ec6f4a04223d)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2218678
-rwxr-xr-x | extra/cr50_rma_open/cr50_rma_open.py | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/extra/cr50_rma_open/cr50_rma_open.py b/extra/cr50_rma_open/cr50_rma_open.py index 85c4a72b40..08e838c7c9 100755 --- a/extra/cr50_rma_open/cr50_rma_open.py +++ b/extra/cr50_rma_open/cr50_rma_open.py @@ -468,13 +468,13 @@ class RMAOpen(object): raise ValueError('%s does not have RMA support. Update to at ' 'least %s' % (version, rma_support)) - def _running_version_is_older(self, comp_ver): - """Returns True if running version is older than comp_ver.""" - comp_ver_fields = [int(field) for field in comp_ver.split('.')] + def _running_version_is_older(self, target_ver): + """Returns True if running version is older than target_ver.""" + target_ver_fields = [int(field) for field in target_ver.split('.')] for i, field in enumerate(self.running_ver_fields): - if field < int(comp_ver_fields[i]): - return True - return False + if field > int(target_ver_fields[i]): + return False + return True def device_matches_devid(self, devid, device): """Return True if the device matches devid. |