diff options
| author | Tom Hughes <tomhughes@chromium.org> | 2022-02-07 13:12:56 -0800 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-04-11 22:30:25 +0000 |
| commit | 7d04c7a1acd9e2eb20b36d4d31fd7aa692507d65 (patch) | |
| tree | a017b63010b806554ce1ec49c3ea68061bfad4d8 | |
| parent | 27e162afc7b3da5c4afec43ad0d057b49faf7203 (diff) | |
| download | chrome-ec-7d04c7a1acd9e2eb20b36d4d31fd7aa692507d65.tar.gz | |
Reland "Enable "cros lint" presubmit check"
This is a reland of commit b294077eed6da053eeca07ce5546830d5404c9a1
Now that zmake has a pylint config file, this should be safe to enable.
Original change's description:
> Enable "cros lint" presubmit check
>
> The cpplint check run by cros lint is disabled with the CPPLINT.cfg file
> since it doesn't apply. Other linters, such as Python and Shell are
> applicable and will be run.
>
> BRANCH=none
> BUG=b:217969201
> TEST=none
>
> Signed-off-by: Tom Hughes <tomhughes@chromium.org>
> Change-Id: Ie9aba283d7bf927913ff834c586ec9e8d0e9e9a1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3444587
> Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
BRANCH=none
BUG=b:217969201
TEST=none
Change-Id: I796a191333128c35903dd60237e677f854132c50
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3581652
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
| -rw-r--r-- | CPPLINT.cfg | 4 | ||||
| -rw-r--r-- | PRESUBMIT.cfg | 1 |
2 files changed, 5 insertions, 0 deletions
diff --git a/CPPLINT.cfg b/CPPLINT.cfg new file mode 100644 index 0000000000..d260909910 --- /dev/null +++ b/CPPLINT.cfg @@ -0,0 +1,4 @@ +set noparent +# Disable cpplint, since EC is a C project that follows Linux kernel style. +# cpplint is called by "cros lint". +exclude_files=.* diff --git a/PRESUBMIT.cfg b/PRESUBMIT.cfg index c726f14214..eac83bb0c5 100644 --- a/PRESUBMIT.cfg +++ b/PRESUBMIT.cfg @@ -23,6 +23,7 @@ cros_license_check : --exclude_regex=^third_party/unacl-curve25519/ [Hook Scripts] +cros lint = cros lint ${PRESUBMIT_FILES} presubmit_check = util/presubmit_check.sh config_option_check = util/config_option_check.py host_command_check = util/host_command_check.sh |