diff options
| author | Zick Wei <zick.wei@quanta.corp-partner.google.com> | 2020-11-18 09:44:42 +0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-11-19 08:05:34 +0000 |
| commit | 62f9993a24dd10eed9300f37c3f8070b6093a62f (patch) | |
| tree | deef076921f23f88770bee29cf39de6b2764edb5 | |
| parent | d948513ac0caecfb1a68cec320ed9d71ee4126e3 (diff) | |
| download | chrome-ec-62f9993a24dd10eed9300f37c3f8070b6093a62f.tar.gz | |
dooly: update red led behavior
This patch enable red led behavior on dooly,
same as puff.
BUG=b:172781906
BRANCH=puff
TEST=verify red led behavior intended,
and below command in VT2 could work.
ectool led power red=100
ectool led power white=100
ectool led power amber=100
Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com>
Change-Id: I4354170cb3e0b1451e757be6a1d01fedebabea6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2545326
Reviewed-by: Andrew McRae <amcrae@chromium.org>
Commit-Queue: Andrew McRae <amcrae@chromium.org>
| -rw-r--r-- | board/dooly/led.c | 20 |
1 files changed, 13 insertions, 7 deletions
diff --git a/board/dooly/led.c b/board/dooly/led.c index bf201cbfc7..fefa8908fe 100644 --- a/board/dooly/led.c +++ b/board/dooly/led.c @@ -35,7 +35,7 @@ enum led_color { LED_OFF = 0, LED_RED, LED_WHITE, - LED_PINK, + LED_AMBER, /* Number of colors, not a color itself */ LED_COLOR_COUNT }; @@ -57,7 +57,7 @@ static int set_color_power(enum led_color color, int duty) case LED_RED: red = 1; break; - case LED_PINK: + case LED_AMBER: white = 1; red = 1; break; @@ -193,7 +193,7 @@ void led_alert(int enable) { if (enable) { /* Overwrite the current signal */ - config_tick(1 * SECOND, 100, LED_WHITE); + config_tick(1 * SECOND, 100, LED_RED); led_tick(); } else { /* Restore the previous signal */ @@ -210,7 +210,7 @@ void show_critical_error(void) { hook_call_deferred(&led_tick_data, -1); if (led_auto_control_is_enabled(EC_LED_ID_POWER_LED)) - set_color(EC_LED_ID_POWER_LED, LED_WHITE, 100); + set_color(EC_LED_ID_POWER_LED, LED_RED, 100); } static int command_led(int argc, char **argv) @@ -229,8 +229,8 @@ static int command_led(int argc, char **argv) set_color(id, LED_RED, 100); } else if (!strcasecmp(argv[1], "white")) { set_color(id, LED_WHITE, 100); - } else if (!strcasecmp(argv[1], "pink")) { - set_color(id, LED_PINK, 100); + } else if (!strcasecmp(argv[1], "amber")) { + set_color(id, LED_AMBER, 100); } else if (!strcasecmp(argv[1], "alert")) { led_alert(1); } else if (!strcasecmp(argv[1], "crit")) { @@ -241,18 +241,24 @@ static int command_led(int argc, char **argv) return EC_SUCCESS; } DECLARE_CONSOLE_COMMAND(led, command_led, - "[debug|red|white|pink|off|alert|crit]", + "[debug|red|white|amber|off|alert|crit]", "Turn on/off LED."); void led_get_brightness_range(enum ec_led_id led_id, uint8_t *brightness_range) { brightness_range[EC_LED_COLOR_WHITE] = 100; + brightness_range[EC_LED_COLOR_RED] = 100; + brightness_range[EC_LED_COLOR_AMBER] = 100; } int led_set_brightness(enum ec_led_id id, const uint8_t *brightness) { if (brightness[EC_LED_COLOR_WHITE]) return set_color(id, LED_WHITE, brightness[EC_LED_COLOR_WHITE]); + else if (brightness[EC_LED_COLOR_RED]) + return set_color(id, LED_RED, brightness[EC_LED_COLOR_RED]); + else if (brightness[EC_LED_COLOR_AMBER]) + return set_color(id, LED_AMBER, brightness[EC_LED_COLOR_AMBER]); else return set_color(id, LED_OFF, 0); } |