summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCaveh Jalali <caveh@chromium.org>2021-03-04 22:56:31 -0800
committerCommit Bot <commit-bot@chromium.org>2021-03-05 15:49:01 +0000
commit777ebeb5aa07298cbefbdad0c61d29a87715d867 (patch)
treeca7cf295564a80e35a2c98f04be34790cff9d2f5
parente8b45a7e33733b2a6e9ccb966be7d1b00ca2b2e6 (diff)
downloadchrome-ec-777ebeb5aa07298cbefbdad0c61d29a87715d867.tar.gz
brya: Enable physical volume buttons
This enables the config option for using physical volume up/down buttons. BRANCH=none BUG=b:173575131 TEST=buildall passes Signed-off-by: Caveh Jalali <caveh@chromium.org> Change-Id: Ib3bb088a88073bd80742e35d0b8a819100163351 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2738398 Reviewed-by: Furquan Shaikh <furquan@chromium.org> Commit-Queue: Furquan Shaikh <furquan@chromium.org>
-rw-r--r--baseboard/brya/baseboard.h3
-rw-r--r--board/brya/board.c8
-rw-r--r--board/brya/board.h2
3 files changed, 5 insertions, 8 deletions
diff --git a/baseboard/brya/baseboard.h b/baseboard/brya/baseboard.h
index 3a91cae866..9995b318ea 100644
--- a/baseboard/brya/baseboard.h
+++ b/baseboard/brya/baseboard.h
@@ -58,6 +58,9 @@
#define CONFIG_THROTTLE_AP
#define CONFIG_CHIPSET_CAN_THROTTLE
+/* Physical Volume Buttons */
+#define CONFIG_VOLUME_BUTTONS
+
/* Common Keyboard Defines */
#define CONFIG_CMD_KEYBOARD
#define CONFIG_KEYBOARD_BOARD_CONFIG
diff --git a/board/brya/board.c b/board/brya/board.c
index 449fabc59d..720437bfe8 100644
--- a/board/brya/board.c
+++ b/board/brya/board.c
@@ -30,11 +30,3 @@ BUILD_ASSERT(ARRAY_SIZE(usb_port_enable) == USB_PORT_COUNT);
const union brya_cbi_fw_config fw_config_defaults = {
.usb_db = DB_USB3_PS8815,
};
-
-/*
- * remove when we enable CONFIG_VOLUME_BUTTONS
- */
-
-void button_interrupt(enum gpio_signal signal)
-{
-}
diff --git a/board/brya/board.h b/board/brya/board.h
index 36603a4387..b96ef610f8 100644
--- a/board/brya/board.h
+++ b/board/brya/board.h
@@ -51,6 +51,8 @@
#define GPIO_POWER_BUTTON_L GPIO_GSC_EC_PWR_BTN_ODL
#define GPIO_RSMRST_L_PGOOD GPIO_SEQ_EC_RSMRST_ODL
#define GPIO_SYS_RESET_L GPIO_SYS_RST_ODL
+#define GPIO_VOLUME_DOWN_L GPIO_EC_VOLDN_BTN_ODL
+#define GPIO_VOLUME_UP_L GPIO_EC_VOLUP_BTN_ODL
#define GPIO_WP_L GPIO_EC_WP_ODL
/* System has back-lit keyboard */