diff options
| author | Shawn Nematbakhsh <shawnn@chromium.org> | 2016-02-03 16:14:51 -0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2016-02-03 21:34:47 -0800 |
| commit | c5e0634054093529263367d926e115c0a332f8b0 (patch) | |
| tree | efe0661f95e0e6da64620deb888fa4c96d5905da | |
| parent | 086e501be397b3e14693b2dfd6a235dcc86844a0 (diff) | |
| download | chrome-ec-c5e0634054093529263367d926e115c0a332f8b0.tar.gz | |
cleanup: Fix signed vs unsigned typing
- ec_response_thermal_get_threshold.value is unsigned, so it can not be
less than zero.
- make power_button_wait_for_release() take a signed int, to match its
existing usage.
BUG=None
TEST=`make buildall -j`
BRANCH=None
Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
Change-Id: Ie5748df3d9904d1e417adc38fee18f8cb3ce9750
Reviewed-on: https://chromium-review.googlesource.com/325840
Commit-Ready: Shawn N <shawnn@chromium.org>
Tested-by: Shawn N <shawnn@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
| -rw-r--r-- | common/power_button.c | 2 | ||||
| -rw-r--r-- | include/power_button.h | 2 | ||||
| -rw-r--r-- | util/ectool.c | 3 |
3 files changed, 2 insertions, 5 deletions
diff --git a/common/power_button.c b/common/power_button.c index 993ad40a6c..e2914bc362 100644 --- a/common/power_button.c +++ b/common/power_button.c @@ -77,7 +77,7 @@ int power_button_is_pressed(void) * @return EC_SUCCESS if ok, or * EC_ERROR_TIMEOUT if power button failed to release */ -int power_button_wait_for_release(unsigned int timeout_us) +int power_button_wait_for_release(int timeout_us) { timestamp_t deadline; timestamp_t now = get_time(); diff --git a/include/power_button.h b/include/power_button.h index d996cbbdbb..3297c411eb 100644 --- a/include/power_button.h +++ b/include/power_button.h @@ -24,7 +24,7 @@ int power_button_is_pressed(void); * @return EC_SUCCESS if ok, or * EC_ERROR_TIMEOUT if power button failed to release */ -int power_button_wait_for_release(unsigned int timeout_us); +int power_button_wait_for_release(int timeout_us); /** * Return non-zero if power button signal asserted at hardware input. diff --git a/util/ectool.c b/util/ectool.c index d551610906..1a641a931b 100644 --- a/util/ectool.c +++ b/util/ectool.c @@ -1489,9 +1489,6 @@ int cmd_thermal_get_threshold_v0(int argc, char *argv[]) if (rv < 0) return rv; - if (r.value < 0) - return -1; - printf("Threshold %d for sensor type %d is %d K.\n", p.threshold_id, p.sensor_type, r.value); |