diff options
| author | Aseda Aboagye <aaboagye@google.com> | 2020-03-24 17:35:15 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-03-26 21:38:16 +0000 |
| commit | 3da80621017eed8462f1825fe073de5db729d428 (patch) | |
| tree | 8c673e4579450307793882127389db9f2c2fc897 | |
| parent | 9d4661b418c5d5856c86333109ab742b9695140a (diff) | |
| download | chrome-ec-3da80621017eed8462f1825fe073de5db729d428.tar.gz | |
icelake: Call hooks around RSMRST when shutting down
When we decide to force the chipset to shutdown, we were just simply
asserting RSMRST_L which was bypassing the hooks around RSMRST (i.e. -
board_has_before_rsmrst() and board_has_after_rsmsrt()).
BUG=b:151680590
BRANCH=None
TEST=Build and flash waddledoo, boot AP and shutdown, verify that
PG_PP1050_ST is no longer asserted.
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Change-Id: I8bc33ff12bf776dab7158bc2efac0637cebdaca4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2119590
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Auto-Submit: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
| -rw-r--r-- | power/icelake.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/power/icelake.c b/power/icelake.c index 2d177dd14f..fe48e22d24 100644 --- a/power/icelake.c +++ b/power/icelake.c @@ -5,6 +5,7 @@ /* Icelake chipset power control module for Chrome EC */ +#include "board_config.h" #include "chipset.h" #include "console.h" #include "gpio.h" @@ -95,7 +96,9 @@ void chipset_force_shutdown(enum chipset_shutdown_reason reason) report_ap_reset(reason); /* Turn off RMSRST_L to meet tPCH12 */ + board_before_rsmrst(0); GPIO_SET_LEVEL(GPIO_PCH_RSMRST_L, 0); + board_after_rsmrst(0); /* Turn off DSW_PWROK to meet tPCH14 */ GPIO_SET_LEVEL(GPIO_PCH_DSW_PWROK, 0); |