diff options
| author | Vincent Palatin <vpalatin@chromium.org> | 2014-06-04 11:45:13 -0700 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-06-11 22:10:55 +0000 |
| commit | b170291c3668807ed923748de2ebc7e707856f92 (patch) | |
| tree | b4cbc548bfd527b72e0fe747ccce7d73b81710a8 | |
| parent | 40ca542a0df0731f7f0df9789c9344581f826d11 (diff) | |
| download | chrome-ec-b170291c3668807ed923748de2ebc7e707856f92.tar.gz | |
zinger: do not cut output on up voltage transitions
Update according to the current PD standard, a monotonic transition
seems mandatory in all cases, so keep the voltage output enabled
when increasing the output voltage.
Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
BRANCH=none
BUG=chrome-os-partner:28331
TEST=connect Zinger to Fruitpie and probe the VBUS voltage during a
transition.
Change-Id: I3c728cc0049ca41536efd4f075139626b7d371da
Reviewed-on: https://chromium-review.googlesource.com/202657
Reviewed-by: Alec Berg <alecaberg@chromium.org>
Commit-Queue: Vincent Palatin <vpalatin@chromium.org>
Tested-by: Vincent Palatin <vpalatin@chromium.org>
| -rw-r--r-- | board/zinger/usb_pd_policy.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/board/zinger/usb_pd_policy.c b/board/zinger/usb_pd_policy.c index 04b04fca6b..e705bdf494 100644 --- a/board/zinger/usb_pd_policy.c +++ b/board/zinger/usb_pd_policy.c @@ -148,7 +148,8 @@ int pd_request_voltage(uint32_t rdo) ((pdo >> 10) & 0x3ff) * 50, (pdo & 0x3ff) * 10, ((rdo >> 10) & 0x3ff) * 10, (rdo & 0x3ff) * 10); - output_disable(); + if (idx - 1 < volt_idx) /* down voltage transition */ + output_disable(); /* TODO discharge ? */ volt_idx = idx - 1; set_output_voltage(voltages[volt_idx].select); |