diff options
| author | Bill Richardson <wfrichar@chromium.org> | 2013-11-11 12:36:03 -0800 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2013-11-11 22:31:16 +0000 |
| commit | eb70d3cda72b3c1bb00fe24d4386288c2d4b114d (patch) | |
| tree | 380793a9e7ef7ed6e64f37ec291382e14a0e4f43 | |
| parent | b2a2821b4d00e91b3514eb4aaa3461eeb0555e6c (diff) | |
| download | chrome-ec-eb70d3cda72b3c1bb00fe24d4386288c2d4b114d.tar.gz | |
Use explicit sizes for lightbar_params fields.
The struct lightbar_params used to communicate lightbar settings between the
AP and the EC uses just "int" for some of its fields. The AP currently uses
32-bit values for "int" in both 64-bit and 32-bit mode, but that's just luck
since C only requires that "int" be at least 16 bits.
This change makes the size explicit.
BUG=none
BRANCH=none
TEST=manual
There should be no visible change.
ectool lightbar params > /tmp/foo
ectool lightbar params /tmp/foo
Change-Id: I4d77c16b3c68e179292b824938d2d012e917ad13
Signed-off-by: Bill Richardson <wfrichar@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/176364
Reviewed-by: Yung-chieh Lo <yjlou@chromium.org>
| -rw-r--r-- | include/ec_commands.h | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/include/ec_commands.h b/include/ec_commands.h index f561681f35..b1e3ed887b 100644 --- a/include/ec_commands.h +++ b/include/ec_commands.h @@ -931,15 +931,15 @@ struct rgb_s { */ struct lightbar_params { /* Timing */ - int google_ramp_up; - int google_ramp_down; - int s3s0_ramp_up; - int s0_tick_delay[2]; /* AC=0/1 */ - int s0a_tick_delay[2]; /* AC=0/1 */ - int s0s3_ramp_down; - int s3_sleep_for; - int s3_ramp_up; - int s3_ramp_down; + int32_t google_ramp_up; + int32_t google_ramp_down; + int32_t s3s0_ramp_up; + int32_t s0_tick_delay[2]; /* AC=0/1 */ + int32_t s0a_tick_delay[2]; /* AC=0/1 */ + int32_t s0s3_ramp_down; + int32_t s3_sleep_for; + int32_t s3_ramp_up; + int32_t s3_ramp_down; /* Oscillation */ uint8_t new_s0; |