diff options
| author | Bill Richardson <wfrichar@chromium.org> | 2014-03-04 13:34:52 -0800 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-03-05 00:27:08 +0000 |
| commit | 362cf0864a46b8ae6a66093cceba6859c801b443 (patch) | |
| tree | e658964bcd704d254b2416c50406e5b5872532af | |
| parent | b805917e43ec2912404892aede64a1265201a4a4 (diff) | |
| download | chrome-ec-362cf0864a46b8ae6a66093cceba6859c801b443.tar.gz | |
Remove time-dependent test from coverage measurements
Compiling with coverage enabled screws up the time that things take, so
don't test for a particular speedup in that case. It fails unreliably.
BUG=chrome-os-partner:20881
BRANCH=ToT
TEST=manual
cd src/platform/ec
make coverage
Before, it failed about half the time. Now it doesn't.
Change-Id: I535f0193bf450a922b486777b296fea1b2768a1a
Signed-off-by: Bill Richardson <wfrichar@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/188790
Reviewed-by: Randall Spangler <rspangler@chromium.org>
| -rw-r--r-- | test/utils.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/test/utils.c b/test/utils.c index 5d4a88d0fe..8ab31d71c8 100644 --- a/test/utils.c +++ b/test/utils.c @@ -97,7 +97,10 @@ static int test_memmove(void) TEST_ASSERT_ARRAY_EQ(buf + 100, buf, len); /* Expected about 4x speed gain. Use 3x because it fluctuates */ +#ifndef TEST_COVERAGE + /* Measuring coverage makes it fluctuate even more, so skip it. */ TEST_ASSERT((t1.val-t0.val) > (t3.val-t2.val) * 3); +#endif /* Test small moves */ memmove(buf + 1, buf, 1); |