diff options
| author | Scott Collyer <scollyer@google.com> | 2022-09-27 09:54:46 -0700 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-09-27 21:45:31 +0000 |
| commit | e19927727d86033d873aef0d36c4002d0fbb579b (patch) | |
| tree | 03c3264eaf573a786eb56bbfb0b22168c4b0115d | |
| parent | 211f8e08e828a0d1f961f01202b4cae25b9a3d22 (diff) | |
| download | chrome-ec-e19927727d86033d873aef0d36c4002d0fbb579b.tar.gz | |
rex: Change GSC packet mode signal to push-pull
ec_gsc_packet_mode was being configured as an open-drain signal, but
this needs to be a push-pull on the EC to work properly with the GSC.
This CL makes that change. Note, there is an issue opened to resolve
the Rex EC GPIO spreadsheet so that manual edits won't be required for
generated.dts. This CL is being submitted to unblock validation while
that issue is being resolved (b/244441996).
BUG=b:248775521
BRANCH=none
TEST=zmake build rex
Verified that EC is now communicating with the GSC
22-09-27 09:49:56.013 [0.416400 VB Verifying hash]
22-09-27 09:49:56.043 [0.453200 VB Received 0xec07]
22-09-27 09:49:56.046 [0.454000 VB Hash mismatch]
22-09-27 09:49:56.050 [0.454700 VB Enable USB-PD]
22-09-27 09:49:56.053 [0.455300 VB Exit]
Signed-off-by: Scott Collyer <scollyer@google.com>
Change-Id: I98fd59f3ac728981f6541aeaac997341a381ccbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3922461
Tested-by: Scott Collyer <scollyer@chromium.org>
Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
Commit-Queue: Scott Collyer <scollyer@chromium.org>
| -rw-r--r-- | zephyr/projects/rex/generated.dts | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/zephyr/projects/rex/generated.dts b/zephyr/projects/rex/generated.dts index 5687de45bf..ae37d3c5bd 100644 --- a/zephyr/projects/rex/generated.dts +++ b/zephyr/projects/rex/generated.dts @@ -65,7 +65,7 @@ enum-name = "GPIO_ENABLE_BACKLIGHT"; }; gpio_ec_gsc_packet_mode: ec_gsc_packet_mode { - gpios = <&gpio7 5 GPIO_ODR_HIGH>; + gpios = <&gpio7 5 GPIO_OUTPUT>; enum-name = "GPIO_PACKET_MODE_EN"; }; gpio_ec_imu_int_r_l: ec_imu_int_r_l { |