summaryrefslogtreecommitdiff
path: root/Makefile.rules
diff options
context:
space:
mode:
authorVadim Bendebury <vbendeb@chromium.org>2017-06-08 12:06:12 -0700
committerchrome-bot <chrome-bot@chromium.org>2017-06-08 18:52:40 -0700
commit61b87c56b669eb10d546c6a3595726ec38a2eaa1 (patch)
tree6b484d46d715b1ca63f36360b3f6f03dc3fd9858 /Makefile.rules
parent9f48b9aa0ce9787d220b89458d6f7774a93ee6f1 (diff)
downloadchrome-ec-61b87c56b669eb10d546c6a3595726ec38a2eaa1.tar.gz
g: do not invoke signer with sudo unless it is necessary
Invoking signer with sudo is required only when signing requires a USB fob. Let's not use it in unless necessary. BRANCH=cr50 BUG=chromium:728751 TEST=verified that Cr50 build succeeds when both using and not using the signing fob. Change-Id: I8f40bd52f1752bfd88ec002f298b991faf7a2512 Reviewed-on: https://chromium-review.googlesource.com/528373 Commit-Ready: Vadim Bendebury <vbendeb@chromium.org> Tested-by: Vadim Bendebury <vbendeb@chromium.org> Reviewed-by: Mary Ruthven <mruthven@chromium.org>
Diffstat (limited to 'Makefile.rules')
-rw-r--r--Makefile.rules2
1 files changed, 1 insertions, 1 deletions
diff --git a/Makefile.rules b/Makefile.rules
index 8765a05776..efc9c1e23e 100644
--- a/Makefile.rules
+++ b/Makefile.rules
@@ -61,7 +61,7 @@ cmd_flat_to_obj = $(CC) -T $(out)/firmware_image.lds -nostdlib $(CPPFLAGS) \
# Allow the .roshared section to overlap other sections (itself)
cmd_ec_elf_to_flat ?= $(OBJCOPY) --set-section-flags .roshared=share \
-O binary $< $@
-cmd_elf_to_signed ?= sudo $(SIGNER) --key=util/signer/$(3) \
+cmd_elf_to_signed ?= $(SIGNER) --key=util/signer/$(3) \
--b --input=$< --format=bin --output=$@.signed $(SIGNER_EXTRAS) \
&& sudo chown $(shell whoami) $@.signed && mv $@.signed $@
cmd_elf_to_dis = $(OBJDUMP) -D $< > $@