diff options
author | Alec Berg <alecaberg@chromium.org> | 2015-02-07 13:43:08 -0800 |
---|---|---|
committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2015-02-08 06:01:53 +0000 |
commit | 911c1821f92bfadc9e0996926ee1b20f7977e562 (patch) | |
tree | 432c0e1e48a274c349cbd84a9c4918be42bc3528 /README | |
parent | 96895743b0287cee5411bfc555d04123af86307d (diff) | |
download | chrome-ec-911c1821f92bfadc9e0996926ee1b20f7977e562.tar.gz |
samus: prevent fast enable/disable charging loop
Bug fix for the new samus charging software workarounds. The problem
occurs occasionally, especially with 5V chargers, and causes the
new software workarounds to get out of sync with the actualy state
of the charging circuit such that when ACOK actually goes high, we
stop charging, and then when ACOK goes low we start charging, and
we end up in a high frequency loop of enabling/disabling charging.
The fix is to add a 100ms delay when ACOK goes low before allowing
charging again. This guarantees that the circuit will settle down
before we try charging again.
BUG=chrome-os-partner:36081
BRANCH=samus
TEST=can reproduce with an EVT2 samus connected to a DVT samus at
~15% battery. On the DVT samus, allow charging from the other other
samus with charge override. Without this change, most of the time
the PD console goes back and forth between enabling and disabling
charging. With this change, we don't can actually charge briefly,
although there is still a problem where VBUS can dip too low and
cause ACOK to actually go low.
Change-Id: If83def862fb58ef3938e2a443e1a081bd27713ec
Signed-off-by: Alec Berg <alecaberg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/247460
Reviewed-by: Shawn N <shawnn@chromium.org>
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Diffstat (limited to 'README')
0 files changed, 0 insertions, 0 deletions