diff options
| author | Aseda Aboagye <aaboagye@google.com> | 2020-01-29 11:19:22 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-01-31 03:41:45 +0000 |
| commit | dbb8bb2d7e71a5b6cb3aa71e3f324a576f6c9a5f (patch) | |
| tree | a7263a800ebac93b1fbf68976133fd9a71444190 /baseboard/dedede/baseboard.c | |
| parent | 036e9f7b214b763524497550aae0ee94df8fd536 (diff) | |
| download | chrome-ec-dbb8bb2d7e71a5b6cb3aa71e3f324a576f6c9a5f.tar.gz | |
waddledoo: Change PP1050_ST power good
The power good for VCCST is actually now a digital signal as opposed to
an analog signal that it used to be. This commit updates the waddledoo
GPIO configuration to account for this fact.
BUG=b:148169171
BRANCH=None
TEST=`make -j BOARD=waddledoo`; flash waddledoo, verify EC boots okay.
Change-Id: I0fe64c07705fa3652b79414a3ec451ebf7204aae
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2028354
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Auto-Submit: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
Diffstat (limited to 'baseboard/dedede/baseboard.c')
| -rw-r--r-- | baseboard/dedede/baseboard.c | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/baseboard/dedede/baseboard.c b/baseboard/dedede/baseboard.c index e68b955849..330abcfd44 100644 --- a/baseboard/dedede/baseboard.c +++ b/baseboard/dedede/baseboard.c @@ -33,14 +33,10 @@ __override int intel_x86_get_pg_ec_dsw_pwrok(void) __override int intel_x86_get_pg_ec_all_sys_pwrgd(void) { /* - * ALL_SYS_PWRGD is an AND of both DRAM PGOOD and VCCST PGOOD. Note - * that this is an inverted power good; a low value means that the power - * is good. Therefore, we are assuming that power is good if voltage is - * no more than 20% of nominal level. + * ALL_SYS_PWRGD is an AND of both DRAM PGOOD and VCCST PGOOD. */ - int vccst = adc_read_channel(ADC_VSNS_PP1050_ST_S); - - return (vccst < 210) && gpio_get_level(GPIO_PG_DRAM_OD); + return gpio_get_level(GPIO_PG_PP1050_ST_OD) && + gpio_get_level(GPIO_PG_DRAM_OD); } void baseboard_chipset_startup(void) |