diff options
| author | Aseda Aboagye <aaboagye@google.com> | 2021-06-28 15:22:11 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-06-29 16:07:22 +0000 |
| commit | 0e729ec359be445cb478eacab23dc982a5e94000 (patch) | |
| tree | 64f1b027e1a64c11331173a2169213df663b3b02 /baseboard/dedede | |
| parent | 2ef205a721c3539251b7ea5bd570334a331625b1 (diff) | |
| download | chrome-ec-0e729ec359be445cb478eacab23dc982a5e94000.tar.gz | |
keeby/dedede: Gate temp sensor access by GPIO
On dedede and keeby boards, the thermistors are powered by the EC's
GPIO_EN_PP3300_A pin. If the thermistors are read before they are
powered then the EC may force a thermal shutdown due to the bad reading.
This commit simply defines CONFIG_TEMP_SENSOR_POWER_GPIO along with a
CONFIG_TEMP_SENSOR_FIRST_READ_DELAY_MS to ensure we don't get any false
positive thermal shutdowns.
BUG=b:192053176
BRANCH=dedede
TEST=Build and flash lalala. Unplug AC charger from DUT, press
refresh+power button to reset DUT, verify that DUT boots up
automatically.
TEST=Repeat above test with madoo.
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Change-Id: I2a49e2f896c4120a8f01f440ea22c9b3763c6589
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2988364
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Auto-Submit: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Diana Z <dzigterman@chromium.org>
Diffstat (limited to 'baseboard/dedede')
| -rw-r--r-- | baseboard/dedede/baseboard.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/baseboard/dedede/baseboard.h b/baseboard/dedede/baseboard.h index 1b16e5dd35..d7409e1c67 100644 --- a/baseboard/dedede/baseboard.h +++ b/baseboard/dedede/baseboard.h @@ -186,6 +186,10 @@ #define CONFIG_USBC_VCONN #define CONFIG_USBC_VCONN_SWAP +/* Temp Sensor */ +#define CONFIG_TEMP_SENSOR_POWER_GPIO GPIO_EN_PP3300_A +#define CONFIG_TEMP_SENSOR_FIRST_READ_DELAY_MS 500 + /* USB PD */ #define CONFIG_USB_PD_ALT_MODE #define CONFIG_USB_PD_ALT_MODE_DFP |