diff options
author | dnojiri <dnojiri@chromium.org> | 2019-12-04 14:52:18 -0800 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2019-12-10 02:14:55 +0000 |
commit | 3973af40f9ca5dd7ba06629b6968b39e912d1c40 (patch) | |
tree | 7ce8b99d8c1b4264709287c6e12bd580495aa4ff /baseboard/grunt | |
parent | 2cb4d29ad22831110d1b5adec820794b6d76fae9 (diff) | |
download | chrome-ec-3973af40f9ca5dd7ba06629b6968b39e912d1c40.tar.gz |
Define board_override_features_flags APIs as overridable
Currently board_override_features_flags0/1 are enabled by
CONFIG_EC_FEATURE_BOARD_OVERRIDE.
This patch defines the callbacks as overridable. It will
allow us to remove CONFIG_EC_FEATURE_BOARD_OVERRIDE and
the redundancy it incurs.
Signed-off-by: dnojiri <dnojiri@chromium.org>
BUG=none
BRANCH=none
TEST=buildall
Change-Id: I0c2870b746879b272ada35b9615b611627a9f426
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1951810
Reviewed-by: Jett Rink <jettrink@chromium.org>
Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
Auto-Submit: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'baseboard/grunt')
-rw-r--r-- | baseboard/grunt/baseboard.c | 7 | ||||
-rw-r--r-- | baseboard/grunt/baseboard.h | 1 |
2 files changed, 1 insertions, 7 deletions
diff --git a/baseboard/grunt/baseboard.c b/baseboard/grunt/baseboard.c index 977b4fc6ed..0726312706 100644 --- a/baseboard/grunt/baseboard.c +++ b/baseboard/grunt/baseboard.c @@ -774,7 +774,7 @@ int board_is_lid_angle_tablet_mode(void) return board_is_convertible(); } -uint32_t board_override_feature_flags0(uint32_t flags0) +__override uint32_t board_override_feature_flags0(uint32_t flags0) { /* * Remove keyboard backlight feature for devices that don't support it. @@ -790,11 +790,6 @@ uint32_t board_override_feature_flags0(uint32_t flags0) return flags0; } -uint32_t board_override_feature_flags1(uint32_t flags1) -{ - return flags1; -} - void board_hibernate(void) { /* diff --git a/baseboard/grunt/baseboard.h b/baseboard/grunt/baseboard.h index 7a2504dcfe..ebbb9534b8 100644 --- a/baseboard/grunt/baseboard.h +++ b/baseboard/grunt/baseboard.h @@ -36,7 +36,6 @@ #define CONFIG_BACKLIGHT_LID_ACTIVE_LOW #define CONFIG_BOARD_VERSION_CUSTOM #define CONFIG_CMD_AP_RESET_LOG -#define CONFIG_EC_FEATURE_BOARD_OVERRIDE #define CONFIG_HIBERNATE_PSL #define CONFIG_HOSTCMD_LPC #define CONFIG_HOSTCMD_SKUID |