diff options
| author | Rob Barnes <robbarnes@google.com> | 2021-01-29 07:20:54 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-05-26 00:15:34 +0000 |
| commit | b657c3e96d1809e82554f8c859afffba358a3567 (patch) | |
| tree | 96ffeeda502d3b2fbec7cf472a56d0370c6d5c1c /baseboard/guybrush | |
| parent | 4304fe55704c5234545d06223f9c632e5b9fe8d4 (diff) | |
| download | chrome-ec-b657c3e96d1809e82554f8c859afffba358a3567.tar.gz | |
usb_common: Assert CCD_MODE when DTS connected
Drive CCD_MODE_ODL from EC when EC sees DTS connected to CCD port.
This will fix some cases where the Cr50 is not able to detect that
a CCD debug cable has been connected.
BUG=b:175056327
TEST=Connect/disconnect SuzyQ cable, see assert/unassert in log
Check gpioget on CR50 and ec, confirm CCD_MODE_ODL is correct
Connect/disconnect charger, do not see assert/unassert in log
Repeat with ServoV4
BRANCH=None
Change-Id: I411e75a47f2e1303ddbd9caa63a9417630c99b46
Signed-off-by: Rob Barnes <robbarnes@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2659282
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Diffstat (limited to 'baseboard/guybrush')
| -rw-r--r-- | baseboard/guybrush/base_gpio.inc | 2 | ||||
| -rw-r--r-- | baseboard/guybrush/baseboard.h | 1 |
2 files changed, 2 insertions, 1 deletions
diff --git a/baseboard/guybrush/base_gpio.inc b/baseboard/guybrush/base_gpio.inc index de3ad60e77..0964cbd8b5 100644 --- a/baseboard/guybrush/base_gpio.inc +++ b/baseboard/guybrush/base_gpio.inc @@ -7,7 +7,7 @@ /* GSC Signals */ GPIO_INT(EC_WP_L, PIN(5, 0), GPIO_INT_BOTH, switch_interrupt) /* Write Protect Enabled */ -GPIO(CCD_MODE_ODL, PIN(C, 6), GPIO_INPUT) /* Case Closed Debug Mode */ +GPIO(CCD_MODE_ODL, PIN(C, 6), GPIO_ODR_HIGH) /* Case Closed Debug Mode */ GPIO(EC_GSC_PACKET_MODE, PIN(B, 1), GPIO_OUT_LOW) /* GSC Packet Mode */ ALTERNATE( PIN_MASK(6, BIT(4) | BIT(5)), 0, MODULE_UART, 0) /* UART_EC_TX_GSC_DBG_RX_R, UART_GSC_DBG_TX_EC_RX_R */ diff --git a/baseboard/guybrush/baseboard.h b/baseboard/guybrush/baseboard.h index 20c298126a..44289a9d7a 100644 --- a/baseboard/guybrush/baseboard.h +++ b/baseboard/guybrush/baseboard.h @@ -14,6 +14,7 @@ #define NPCX_UART_MODULE2 1 /* GPIO64/65 are used as UART pins. */ /* Optional features */ +#define CONFIG_ASSERT_CCD_MODE_ON_DTS_CONNECT #define CONFIG_SYSTEM_UNLOCKED /* Allow dangerous commands while in dev. */ #define CONFIG_LTO /* Link-Time Optimizations to reduce code size */ #define CONFIG_I2C_DEBUG /* Print i2c traces */ |