diff options
| author | Scott Collyer <scollyer@google.com> | 2019-03-08 10:26:32 -0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-03-13 21:05:00 -0700 |
| commit | bca03f28bd2192288b7f540707b42f76198aa2f7 (patch) | |
| tree | 6ee4cbc377439518b9a1440f728c942d32993428 /baseboard/hatch | |
| parent | e7edd0ebedf85c13a1c97deb302c44655f4ca2d9 (diff) | |
| download | chrome-ec-bca03f28bd2192288b7f540707b42f76198aa2f7.tar.gz | |
hatch: Disable HW_RAMP until bq25710 ICO mode is changed
The charge hw ramp implementation in the bq25710 is implemented by
enabling ICO (input current optimizer) mode, waiting for it to
complete, then reading optimized current value from the IIN_DPM
register. This is not the correct use case for ICO mode. It has
certain issues, the most serious of which is that if a battery isn't
present or if the battery doesn't have enough charge to power the
system, it will cause PPVAR_VSYS to collapse.
To avoid the issue mentioned above, disable the hw ramp config until
the hw ramp implementation of the bq25710 is reworked.
BUG=b:126229130
BRANCH=none
TEST=make BOARD=hatch and verifed that ICO mode is not longer
activated.
Change-Id: I736c21ad269742650cc62939995c4caa77154b6b
Signed-off-by: Scott Collyer <scollyer@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1512135
Commit-Ready: Scott Collyer <scollyer@chromium.org>
Tested-by: Scott Collyer <scollyer@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
Diffstat (limited to 'baseboard/hatch')
| -rw-r--r-- | baseboard/hatch/baseboard.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/baseboard/hatch/baseboard.h b/baseboard/hatch/baseboard.h index 94c8b6fad7..85e65e74b8 100644 --- a/baseboard/hatch/baseboard.h +++ b/baseboard/hatch/baseboard.h @@ -70,7 +70,6 @@ /* Common charger defines */ #define CONFIG_CHARGE_MANAGER -#define CONFIG_CHARGE_RAMP_HW #define CONFIG_CHARGER #define CONFIG_CHARGER_BQ25710 #define CONFIG_CHARGER_DISCHARGE_ON_AC |