summaryrefslogtreecommitdiff
path: root/baseboard/intelrvp
diff options
context:
space:
mode:
authorKattamuri, Sowjanya <sowjanya.kattamuri@intel.com>2020-04-02 14:58:01 +0530
committerCommit Bot <commit-bot@chromium.org>2020-04-08 22:23:06 +0000
commit581e6f9a83d468d02f40c2c0d811fc25c73be54b (patch)
treeca5d674cd254cc373dcb34bcf84a60ad8045f9f3 /baseboard/intelrvp
parentf327ba4fcf20a314bba988b7aac778bbaf94101c (diff)
downloadchrome-ec-581e6f9a83d468d02f40c2c0d811fc25c73be54b.tar.gz
Power_x86: Correct the debounce delay for SYS_RESET_L signal
RVP uses MAX6818 to digitize the apreset physical button. The EC SYS_RESET_L is connected to input of the digitizer. From MAX6818 Data sheet, range of 'Debounce Duration' is Minimum - 20 ms, Typical - 40 ms, Maximum - 80 ms. Hence, implemented an override function to wait for an appropriate delay. BUG=b:153128296 BRANCH=none TEST=manually tested on TGLRVP, aprset EC console command triggers warm boot Change-Id: I4f883c925a82d32bfaaeed8120671869d3744843 Signed-off-by: Deepti Deshatty <deepti.deshatty@intel.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2134326 Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
Diffstat (limited to 'baseboard/intelrvp')
-rw-r--r--baseboard/intelrvp/baseboard.c11
1 files changed, 11 insertions, 0 deletions
diff --git a/baseboard/intelrvp/baseboard.c b/baseboard/intelrvp/baseboard.c
index 1992d056ef..bf1127bb76 100644
--- a/baseboard/intelrvp/baseboard.c
+++ b/baseboard/intelrvp/baseboard.c
@@ -15,6 +15,7 @@
#include "power.h"
#include "temp_sensor.h"
#include "thermistor.h"
+#include "timer.h"
/* Wake-up pins for hibernate */
const enum gpio_signal hibernate_wake_pins[] = {
@@ -180,3 +181,13 @@ int ioexpander_read_intelrvp_version(int *port0, int *port1)
I2C_ADDR_PCA9555_BOARD_ID_GPIO,
PCA9555_CMD_INPUT_PORT_1, port1);
}
+
+__override void intel_x86_sys_reset_delay(void)
+{
+ /*
+ * From MAX6818 Data sheet, Range of 'Debounce Duaration' is
+ * Minimum - 20 ms, Typical - 40 ms, Maximum - 80 ms.
+ */
+ udelay(60 * MSEC);
+}
+