diff options
| author | Keith Short <keithshort@chromium.org> | 2020-02-06 12:09:15 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-02-07 21:07:20 +0000 |
| commit | f74a01dc024fea492d970300c679aa6acaf2cacc (patch) | |
| tree | cb7b01cabfe7de2ad3b00b254c070a39e967b6c2 /baseboard/volteer/baseboard.c | |
| parent | 04eac8d4613667571c39b82fb285acfa38de9f38 (diff) | |
| download | chrome-ec-f74a01dc024fea492d970300c679aa6acaf2cacc.tar.gz | |
volteer: Increase I2C bus speeds for USB C0 and C1
The I2C bus speeds were set to 100 kHz for board bringup on the USB C0
and USB C1 I2C buses. Running these buses at 100 kHz causes too much
latency in the PD message handling and can cause the EC to exceed PD
specification timeouts.
At 100 kHz, TCPC interrupt latency for SOP message is 3-5 ms, overall
latency for Source_Cap to Request is 15ms.
At 400 kHz, TCPC interrupt latency is less than 34 us, overall latency
for Source_Cap to Request is 3ms.
At 1 MHz, Source_Cap to Request latency reduces to 2.3ms.
BUG=b:144863533
BRANCH=none
TEST=make buildall
TEST=verify all I2C devices found on USB C0 and USB C1
TEST=with battery disconnected, verify jump to RW firmware works
Change-Id: If31dc54a1a2de202870d5bf2e173d5a0e21cf94e
Signed-off-by: Keith Short <keithshort@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2042673
Tested-by: Eric Herrmann <eherrmann@google.com>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: caveh jalali <caveh@chromium.org>
Diffstat (limited to 'baseboard/volteer/baseboard.c')
| -rw-r--r-- | baseboard/volteer/baseboard.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/baseboard/volteer/baseboard.c b/baseboard/volteer/baseboard.c index 5205406660..31d47900f8 100644 --- a/baseboard/volteer/baseboard.c +++ b/baseboard/volteer/baseboard.c @@ -127,16 +127,14 @@ const struct i2c_port_t i2c_ports[] = { { .name = "usb_c0", .port = I2C_PORT_USB_C0, - /* TODO: design supports 1 MHz, set to 100 KHz for bringup */ - .kbps = 100, + .kbps = 400, .scl = GPIO_EC_I2C1_USB_C0_SCL, .sda = GPIO_EC_I2C1_USB_C0_SDA, }, { .name = "usb_c1", .port = I2C_PORT_USB_C1, - /* TODO: design supports 1 MHz, set to 100 KHz for bringup */ - .kbps = 100, + .kbps = 400, .scl = GPIO_EC_I2C2_USB_C1_SCL, .sda = GPIO_EC_I2C2_USB_C1_SDA, }, |