summaryrefslogtreecommitdiff
path: root/baseboard/volteer
diff options
context:
space:
mode:
authorAbe Levkoy <alevkoy@chromium.org>2019-11-12 19:46:03 -0800
committerCommit Bot <commit-bot@chromium.org>2019-11-13 19:47:41 +0000
commit65b5a9994d7759263d540d5781038e019f964d27 (patch)
treeed1f4dc5359fa5f80ad707e78764c33bab412076 /baseboard/volteer
parentdfec8a5585820826cf4e669f694895d880a53820 (diff)
downloadchrome-ec-65b5a9994d7759263d540d5781038e019f964d27.tar.gz
volteer: Cleanup LED configuration
Place it in its own section and remove stale TODO. BUG=b:139554899 TEST=make buildall BRANCH=none Change-Id: Iac64a4c0d29091de68213aa719a0b48fcf369177 Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1913862 Reviewed-by: Keith Short <keithshort@chromium.org> Tested-by: Keith Short <keithshort@chromium.org>
Diffstat (limited to 'baseboard/volteer')
-rw-r--r--baseboard/volteer/baseboard.h13
1 files changed, 6 insertions, 7 deletions
diff --git a/baseboard/volteer/baseboard.h b/baseboard/volteer/baseboard.h
index 07d59b999e..ccce756ac6 100644
--- a/baseboard/volteer/baseboard.h
+++ b/baseboard/volteer/baseboard.h
@@ -21,13 +21,6 @@
#define CONFIG_CRC8
#define CONFIG_CROS_BOARD_INFO
#define CONFIG_HIBERNATE_PSL
-#define CONFIG_LED_COMMON
-/* TODO(b/140557020): Define CONFIG_LED_ONOFF_STATES and
- * CONFIG_LED_ONOFF_STATES_BAT_LOW when CONFIG_CHARGER is defined.
- */
-#define CONFIG_LED_PWM
-/* Although there are 2 LEDs, they are both controlled by the same lines. */
-#define CONFIG_LED_PWM_COUNT 1
#define CONFIG_PWM
#define CONFIG_VBOOT_HASH
#define CONFIG_VSTORE
@@ -78,6 +71,12 @@
/* TODO: b/143809318 enable cut off */
/* #define CONFIG_BATTERY_CUT_OFF */
+/* Common LED defines */
+#define CONFIG_LED_COMMON
+#define CONFIG_LED_PWM
+/* Although there are 2 LEDs, they are both controlled by the same lines. */
+#define CONFIG_LED_PWM_COUNT 1
+
/* USB Type C and USB PD defines */
/* Enable the new USB-C PD stack */
#define CONFIG_USB_SM_FRAMEWORK