summaryrefslogtreecommitdiff
path: root/baseboard/zork/variant_dalboz.c
diff options
context:
space:
mode:
authorEdward Hill <ecgh@chromium.org>2020-06-02 18:28:26 -0600
committerCommit Bot <commit-bot@chromium.org>2020-06-03 05:39:13 +0000
commit5124d453200ce13dfd8badfcd2c56e57334df2df (patch)
treeb397b594cf13c79c77beeebf7bb7ec5b2c03bb86 /baseboard/zork/variant_dalboz.c
parentce804f34ccb7c65fc4711c01eac63ceb8c008e26 (diff)
downloadchrome-ec-5124d453200ce13dfd8badfcd2c56e57334df2df.tar.gz
Zork: Switch PS8743 from IOEX_USB_C1_DATA_EN to I2C
Align all Zork devices on using I2C control of PS8743 mux mode, and stop using IOEX_USB_C1_DATA_EN signal/pin. This matches what we were already doing for Dalboz, and gives power savings in both S0 and S3 when nothing is plugged in and mux is set to none. BUG=b:157951317 BRANCH=none TEST=external display and i2ctrace on ezkinil Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: Id1c8b172a99bb25bed8b57e90686d933447432f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2227589 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
Diffstat (limited to 'baseboard/zork/variant_dalboz.c')
-rw-r--r--baseboard/zork/variant_dalboz.c22
1 files changed, 0 insertions, 22 deletions
diff --git a/baseboard/zork/variant_dalboz.c b/baseboard/zork/variant_dalboz.c
index 6c7efda481..517532a7bb 100644
--- a/baseboard/zork/variant_dalboz.c
+++ b/baseboard/zork/variant_dalboz.c
@@ -174,34 +174,12 @@ const struct usb_mux usbc0_sbu_mux = {
.driver = &usbc0_sbu_mux_driver,
};
-static int usbc1_hpd_set_mux(const struct usb_mux *me, mux_state_t mux_state)
-{
- if (mux_state & USB_PD_MUX_DP_ENABLED)
- /* Enable IN_HPD on the DB */
- ioex_set_level(IOEX_USB_C1_HPD_IN_DB, 1);
- else
- /* Disable IN_HPD on the DB */
- ioex_set_level(IOEX_USB_C1_HPD_IN_DB, 0);
-
- return EC_SUCCESS;
-}
-
-const struct usb_mux_driver usbc1_hpd_mux_driver = {
- .set = usbc1_hpd_set_mux,
-};
-
-const struct usb_mux usbc1_hpd_mux = {
- .usb_port = USBC_PORT_C1,
- .driver = &usbc1_hpd_mux_driver,
-};
-
struct usb_mux usbc1_amd_fp5_usb_mux = {
.usb_port = USBC_PORT_C1,
.i2c_port = I2C_PORT_USB_AP_MUX,
.i2c_addr_flags = AMD_FP5_MUX_I2C_ADDR_FLAGS,
.driver = &amd_fp5_usb_mux_driver,
.flags = USB_MUX_FLAG_SET_WITHOUT_FLIP,
- .next_mux = &usbc1_hpd_mux,
};
struct usb_mux usb_muxes[] = {