diff options
| author | Ting Shen <phoenixshen@google.com> | 2021-05-20 18:16:41 +0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-05-27 09:17:00 +0000 |
| commit | 00d63619edf7b6c1f62d7cfce7a2bd520635dbd3 (patch) | |
| tree | dd379764d34d67abb3cac4c40499321c33651842 /baseboard | |
| parent | e9aae45d73c326331b07a0db171e64d73402907f (diff) | |
| download | chrome-ec-00d63619edf7b6c1f62d7cfce7a2bd520635dbd3.tar.gz | |
base_state: implement basestate host command
This CL introduces an unified method to force base attach/detach, to
deprecate the hard-coded gpio pin name table in
hammerd/hammertests/common.py.
Also modifies base_force_state to use the same parameter type as host
command.
BUG=b:188625010
TEST=manually,
run `ectool basestate attach|detach|reset` on coachz
BRANCH=trogdor,kukui
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: I5235661727cbbd15015c49d588ec70605e4a33e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2910472
Reviewed-by: Wai-Hong Tam <waihong@google.com>
Tested-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Diffstat (limited to 'baseboard')
| -rw-r--r-- | baseboard/kukui/base_detect_kukui.c | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/baseboard/kukui/base_detect_kukui.c b/baseboard/kukui/base_detect_kukui.c index ac7d9f7616..68542b4fb6 100644 --- a/baseboard/kukui/base_detect_kukui.c +++ b/baseboard/kukui/base_detect_kukui.c @@ -200,9 +200,9 @@ static void pogo_chipset_shutdown(void) } DECLARE_HOOK(HOOK_CHIPSET_SHUTDOWN, pogo_chipset_shutdown, HOOK_PRIO_DEFAULT); -void base_force_state(int state) +void base_force_state(enum ec_set_base_state_cmd state) { - if (state != 1 && state != 0) { + if (state >= EC_SET_BASE_STATE_RESET) { CPRINTS("BD forced reset"); pogo_chipset_init(); return; @@ -210,9 +210,11 @@ void base_force_state(int state) gpio_disable_interrupt(GPIO_POGO_ADC_INT_L); pogo_type = (state == 1 ? DEVICE_TYPE_KEYBOARD : DEVICE_TYPE_DETACHED); - base_set_device_type(state == 1 ? DEVICE_TYPE_KEYBOARD : - DEVICE_TYPE_DETACHED); - CPRINTS("BD forced %sconnected", state == 1 ? "" : "dis"); + base_set_device_type(state == EC_SET_BASE_STATE_ATTACH + ? DEVICE_TYPE_KEYBOARD + : DEVICE_TYPE_DETACHED); + CPRINTS("BD forced %sconnected", state == EC_SET_BASE_STATE_ATTACH ? + "" : "dis"); } #ifdef VARIANT_KUKUI_POGO_DOCK |