diff options
| author | Scott Collyer <scollyer@google.com> | 2021-04-28 07:00:33 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-05-02 02:47:55 +0000 |
| commit | 3515918efb13d8920a28f0c429b0a77d5cb0c94d (patch) | |
| tree | 9cf5008960a25f53e814be5a403c294767f7558e /baseboard | |
| parent | 00f1fed18d7a75792f6a4a849bb39d33590a5f9c (diff) | |
| download | chrome-ec-3515918efb13d8920a28f0c429b0a77d5cb0c94d.tar.gz | |
honeybuns: Fix discover mode reply for USB 2.0 signals
Bit 7 of the DP capabilities (Discover mode response) message is for
USB r2.0 Signaling Not Used. This bit was set for honeybuns, which is
incorrect. This can cause some host machines (Mac) to stop enumerating
USB r2.0 devices when 4 lane DP is selected.
BUG=b:186629871
BRANCH=quiche
TEST=Provided ODM partner with this bit being set to 0 and they
verifed that USB2.0 enumeration is not lost when DP is connected.
Signed-off-by: Scott Collyer <scollyer@google.com>
Change-Id: I137a41dd641c0c019a649c5fbcc37bc44775e30a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2856289
Commit-Queue: Scott Collyer <scollyer@chromium.org>
Tested-by: Scott Collyer <scollyer@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Diffstat (limited to 'baseboard')
| -rw-r--r-- | baseboard/honeybuns/usb_pd_policy.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/baseboard/honeybuns/usb_pd_policy.c b/baseboard/honeybuns/usb_pd_policy.c index 950c989907..09d0c299aa 100644 --- a/baseboard/honeybuns/usb_pd_policy.c +++ b/baseboard/honeybuns/usb_pd_policy.c @@ -400,9 +400,9 @@ static int svdm_response_svids(int port, uint32_t *payload) const uint32_t vdo_dp_modes[1] = { VDO_MODE_DP(/* Must support C and E. D is required for 2 lanes */ - MODE_DP_PIN_C | MODE_DP_PIN_D | MODE_DP_PIN_D, + MODE_DP_PIN_C | MODE_DP_PIN_D | MODE_DP_PIN_E, 0, /* DFP pin cfg supported */ - 1, /* no usb2.0 signalling in AMode */ + 0, /* usb2.0 signalling in AMode may be req */ CABLE_RECEPTACLE, /* its a receptacle */ MODE_DP_V13, /* DPv1.3 Support, no Gen2 */ MODE_DP_SNK) /* Its a sink only */ |