diff options
| author | Tom Hughes <tomhughes@chromium.org> | 2022-10-14 08:55:18 -0700 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-10-19 20:56:04 +0000 |
| commit | 0d1b98c7183e8bc058a00ace0c30c1ea0e736a8a (patch) | |
| tree | 6ff876b5578d5c83285dd90c295f0b697efc238c /baseboard | |
| parent | e66c6fe6efab16bed9b06c1b9e349c71eddb5a3f (diff) | |
| download | chrome-ec-0d1b98c7183e8bc058a00ace0c30c1ea0e736a8a.tar.gz | |
tree: Enable warning for fallthrough in switch statements
The EC code has generally been good about adding comments about
intentional fallthrough in switch statements, but there were a few cases
without comments (e.g., https://crrev.com/c/3949622). Enabling
-Wimplicit-fallthrough generates a compiler warning if the fallthrough
is not annotated with __attribute__((fallthrough)). For convenience, we
add a "__fallthrough" macro for this attribute.
See https://clang.llvm.org/docs/AttributeReference.html#fallthrough and
https://gcc.gnu.org/onlinedocs/gcc/Statement-Attributes.html.
BRANCH=none
BUG=b:253644823
TEST=make buildall
LOW_COVERAGE_REASON=legacy code
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I9f4d6049f4507a25ce706675d159b70e28b4b825
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3957420
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Diffstat (limited to 'baseboard')
| -rw-r--r-- | baseboard/intelrvp/led_states.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/baseboard/intelrvp/led_states.c b/baseboard/intelrvp/led_states.c index 8629085c4f..6bcee159a3 100644 --- a/baseboard/intelrvp/led_states.c +++ b/baseboard/intelrvp/led_states.c @@ -39,7 +39,7 @@ static enum led_states led_get_state(void) new_state = STATE_CHARGING_FULL_CHARGE; break; } - /* Intentional fall-through */ + __fallthrough; case PWR_STATE_DISCHARGE /* and PWR_STATE_DISCHARGE_FULL */: if (chipset_in_state(CHIPSET_STATE_ON)) new_state = STATE_DISCHARGE_S0; |