diff options
| author | Boris Mittelberg <bmbm@google.com> | 2021-04-13 22:49:42 +0000 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-05-10 22:34:46 +0000 |
| commit | fa985803d6bd7c76b8eddc49d1bab4434cc545f3 (patch) | |
| tree | ff2645c8fdd0c8c36a68d89b3e4536f2bc538643 /baseboard | |
| parent | 3a2f77758104a581ade2ecb406b8d099eada6a90 (diff) | |
| download | chrome-ec-fa985803d6bd7c76b8eddc49d1bab4434cc545f3.tar.gz | |
mkbp: Move key simulation to input devices
Today some platforms include MKBP_KEYBOARD because they use side buttons,
switches or other events that share the same driver with MKBP keyboard.
Those platforms don't enable KEYSCAN task. The CL is moving key emulation
functionality to MKBP input devices, to make a clear separation
between the real keyboard usage and emulation/buttons/switches/etc.
All boards that were selecting `CONFIG_KEYBOARD_PROTOCOL_MKBP` without
KEYSCAN task are now updated to select `CONFIG_MKBP_INPUT_DEVICES`
BUG=b:170966461
BRANCH=main,firmware-dedede-13606.B,firmware-volteer-13672.B-main
TEST=None
Signed-off-by: Boris Mittelberg <bmbm@google.com>
Change-Id: I515140ebf6e175f4b29991329f92266ffca232a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2824044
Diffstat (limited to 'baseboard')
| -rw-r--r-- | baseboard/kalista/baseboard.h | 2 | ||||
| -rw-r--r-- | baseboard/kukui/baseboard.h | 2 | ||||
| -rw-r--r-- | baseboard/trogdor/baseboard.h | 2 |
3 files changed, 1 insertions, 5 deletions
diff --git a/baseboard/kalista/baseboard.h b/baseboard/kalista/baseboard.h index 5cda6c310c..7579acd2d7 100644 --- a/baseboard/kalista/baseboard.h +++ b/baseboard/kalista/baseboard.h @@ -25,7 +25,7 @@ #define CONFIG_DEDICATED_RECOVERY_BUTTON #define CONFIG_EMULATED_SYSRQ #define CONFIG_LED_COMMON -#define CONFIG_KEYBOARD_PROTOCOL_MKBP +#define CONFIG_MKBP_INPUT_DEVICES #define CONFIG_MKBP_USE_HOST_EVENT #define CONFIG_DPTF #define CONFIG_FLASH_SIZE_BYTES 0x80000 diff --git a/baseboard/kukui/baseboard.h b/baseboard/kukui/baseboard.h index 9aa1362534..f4869ce943 100644 --- a/baseboard/kukui/baseboard.h +++ b/baseboard/kukui/baseboard.h @@ -239,8 +239,6 @@ #undef CONFIG_PSTORE #define CONFIG_TASK_PROFILING -#define CONFIG_KEYBOARD_PROTOCOL_MKBP -#define CONFIG_MKBP_EVENT #define CONFIG_MKBP_USE_GPIO /* diff --git a/baseboard/trogdor/baseboard.h b/baseboard/trogdor/baseboard.h index 8e3dbe4b1e..570bf16f83 100644 --- a/baseboard/trogdor/baseboard.h +++ b/baseboard/trogdor/baseboard.h @@ -44,8 +44,6 @@ #define CONFIG_HOSTCMD_SPS #define CONFIG_HOST_COMMAND_STATUS #define CONFIG_HOSTCMD_SECTION_SORTED -#define CONFIG_MKBP_EVENT -#define CONFIG_KEYBOARD_PROTOCOL_MKBP #define CONFIG_KEYBOARD_COL2_INVERTED #define CONFIG_MKBP_USE_GPIO |