diff options
author | Sam Hurst <shurst@google.com> | 2020-02-21 09:00:29 -0800 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2020-02-22 03:14:27 +0000 |
commit | aebb58b99064567f25b1c407aeb5d193dc4042c3 (patch) | |
tree | cfd594c639b80659c4831bfe65b525859e9bb1b4 /baseboard | |
parent | a9666e310606cbd1a54d32fa0cb200f16cf1d451 (diff) | |
download | chrome-ec-aebb58b99064567f25b1c407aeb5d193dc4042c3.tar.gz |
TCPMV1/2: Make the PD Config Flags more consistent
The current use of the PD Config Flags are a bit confusing and
has been changed to the following:
The CONFIG_USB_POWER_DELIVERY flag is used to enable and disable
the TCPMv1 and TCPMv2 stacks. And when CONFIG_USB_POWER_DELIVERY
is enabled, one of the following must be enabled:
CONFIG_USB_PD_TCPMV1 - legacy power delivery state machine
CONFIG_USB_PD_TCPMV2 - current power delivery state machine
BUG=b:149993808
BRANCH=none
TEST=make -j buildall
Change-Id: Ie3f8615a75b15b4f1c703f57f3db9e152a471238
Signed-off-by: Sam Hurst <shurst@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2068519
Reviewed-by: Diana Z <dzigterman@chromium.org>
Diffstat (limited to 'baseboard')
-rw-r--r-- | baseboard/dedede/baseboard.h | 2 | ||||
-rw-r--r-- | baseboard/dragonegg/baseboard.h | 2 | ||||
-rw-r--r-- | baseboard/grunt/baseboard.h | 1 | ||||
-rw-r--r-- | baseboard/hatch/baseboard.h | 1 | ||||
-rw-r--r-- | baseboard/intelrvp/baseboard.h | 1 | ||||
-rw-r--r-- | baseboard/kalista/baseboard.h | 1 | ||||
-rw-r--r-- | baseboard/kukui/baseboard.h | 1 | ||||
-rw-r--r-- | baseboard/octopus/baseboard.h | 1 | ||||
-rw-r--r-- | baseboard/volteer/baseboard.h | 3 | ||||
-rw-r--r-- | baseboard/zork/baseboard.h | 3 |
10 files changed, 13 insertions, 3 deletions
diff --git a/baseboard/dedede/baseboard.h b/baseboard/dedede/baseboard.h index 1494bdc79f..4f3dd6551b 100644 --- a/baseboard/dedede/baseboard.h +++ b/baseboard/dedede/baseboard.h @@ -168,7 +168,7 @@ #define CONFIG_USB_PD_DECODE_SOP #define CONFIG_USB_PID 0x5042 #define CONFIG_USB_POWER_DELIVERY -#define CONFIG_USB_SM_FRAMEWORK +#define CONFIG_USB_PD_TCPMV2 #define CONFIG_USB_TYPEC_DRP_ACC_TRYSRC /* Define typical operating power and max power. */ diff --git a/baseboard/dragonegg/baseboard.h b/baseboard/dragonegg/baseboard.h index d0d3c31486..7365891000 100644 --- a/baseboard/dragonegg/baseboard.h +++ b/baseboard/dragonegg/baseboard.h @@ -81,6 +81,8 @@ #define CONFIG_USB_PD_TCPM_ITE_ON_CHIP /* C0 & C1 TCPC: ITE EC */ #define CONFIG_USB_PD_TCPM_TUSB422 /* C1 TCPC: TUSB422 */ #define CONFIG_USB_POWER_DELIVERY +#define CONFIG_USB_PD_TCPMV1 + /* * TODO (b/111281797): DragonEgg has 3 ports. Only adding support for the port * on the MLB for now. In addition, this config option will likely move to diff --git a/baseboard/grunt/baseboard.h b/baseboard/grunt/baseboard.h index cf6fb1fc39..eadd60a104 100644 --- a/baseboard/grunt/baseboard.h +++ b/baseboard/grunt/baseboard.h @@ -108,6 +108,7 @@ #define CONFIG_KEYBOARD_PROTOCOL_8042 #define CONFIG_USB_POWER_DELIVERY +#define CONFIG_USB_PD_TCPMV1 #define CONFIG_CMD_PD_CONTROL #define CONFIG_USB_PD_ALT_MODE #define CONFIG_USB_PD_ALT_MODE_DFP diff --git a/baseboard/hatch/baseboard.h b/baseboard/hatch/baseboard.h index 09ea0056a7..78bd66def2 100644 --- a/baseboard/hatch/baseboard.h +++ b/baseboard/hatch/baseboard.h @@ -120,6 +120,7 @@ /* USB Type C and USB PD defines */ #define CONFIG_USB_POWER_DELIVERY +#define CONFIG_USB_PD_TCPMV1 #define CONFIG_USB_PD_PORT_MAX_COUNT 2 #define CONFIG_USB_PD_MAX_SINGLE_SOURCE_CURRENT TYPEC_RP_3A0 #define CONFIG_USB_PD_TCPC_LOW_POWER diff --git a/baseboard/intelrvp/baseboard.h b/baseboard/intelrvp/baseboard.h index 395b757f4b..fe19351bac 100644 --- a/baseboard/intelrvp/baseboard.h +++ b/baseboard/intelrvp/baseboard.h @@ -84,6 +84,7 @@ #define CONFIG_USB_PD_TRY_SRC #define CONFIG_USB_PD_VBUS_MEASURE_NOT_PRESENT #define CONFIG_USB_POWER_DELIVERY +#define CONFIG_USB_PD_TCPMV1 /* USB MUX */ #ifdef CONFIG_USB_MUX_VIRTUAL diff --git a/baseboard/kalista/baseboard.h b/baseboard/kalista/baseboard.h index 8061205684..6dbccb73b7 100644 --- a/baseboard/kalista/baseboard.h +++ b/baseboard/kalista/baseboard.h @@ -96,6 +96,7 @@ #define CONFIG_USB_PD_TCPM_TCPCI #define CONFIG_USB_PD_TCPM_PS8751 #define CONFIG_USB_POWER_DELIVERY +#define CONFIG_USB_PD_TCPMV1 #define CONFIG_USBC_SS_MUX #define CONFIG_USBC_SS_MUX_DFP_ONLY #define CONFIG_USBC_VCONN diff --git a/baseboard/kukui/baseboard.h b/baseboard/kukui/baseboard.h index 4389685172..f09fba85e1 100644 --- a/baseboard/kukui/baseboard.h +++ b/baseboard/kukui/baseboard.h @@ -178,6 +178,7 @@ /* USB PD config */ #define CONFIG_CHARGE_MANAGER #define CONFIG_USB_POWER_DELIVERY +#define CONFIG_USB_PD_TCPMV1 #define CONFIG_USB_PD_ALT_MODE #define CONFIG_USB_PD_ALT_MODE_DFP #define CONFIG_USB_PD_DUAL_ROLE diff --git a/baseboard/octopus/baseboard.h b/baseboard/octopus/baseboard.h index 44ea94286b..2bbcff6d32 100644 --- a/baseboard/octopus/baseboard.h +++ b/baseboard/octopus/baseboard.h @@ -184,6 +184,7 @@ /* Common USB-C defines */ #define CONFIG_USB_POWER_DELIVERY +#define CONFIG_USB_PD_TCPMV1 #define CONFIG_USB_PD_PORT_MAX_COUNT 2 #define CONFIG_USB_PD_DUAL_ROLE #define CONFIG_USB_PD_LOGGING diff --git a/baseboard/volteer/baseboard.h b/baseboard/volteer/baseboard.h index 01aeb1871f..7fd84e7acf 100644 --- a/baseboard/volteer/baseboard.h +++ b/baseboard/volteer/baseboard.h @@ -148,7 +148,7 @@ /* Enable the new USB-C PD stack */ /* TODO: b/145756626 - re-enable once all blocking issues resolved */ #if 0 -#define CONFIG_USB_SM_FRAMEWORK +#define CONFIG_USB_PD_TCPMV2 #define CONFIG_USB_TYPEC_SM #define CONFIG_USB_PRL_SM #define CONFIG_USB_PE_SM @@ -162,6 +162,7 @@ #endif #define CONFIG_USB_POWER_DELIVERY +#define CONFIG_USB_PD_TCPMV1 #define CONFIG_USB_PD_ALT_MODE #define CONFIG_USB_PD_ALT_MODE_DFP #define CONFIG_USB_PD_DISCHARGE_PPC diff --git a/baseboard/zork/baseboard.h b/baseboard/zork/baseboard.h index 1052a1e0d6..e4f29ad839 100644 --- a/baseboard/zork/baseboard.h +++ b/baseboard/zork/baseboard.h @@ -116,7 +116,8 @@ /* Enable the TCPMv2 PD stack */ #define CONFIG_USB_PE_SM #define CONFIG_USB_PRL_SM -#define CONFIG_USB_SM_FRAMEWORK +#define CONFIG_USB_PD_TCPMV2 +#define CONFIG_USB_PD_DECODE_SOP #define CONFIG_USB_TYPEC_SM #define CONFIG_USB_TYPEC_DRP_ACC_TRYSRC |