diff options
| author | Diana Z <dzigterman@chromium.org> | 2019-02-27 13:14:44 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-03-01 01:09:02 -0800 |
| commit | e56fb445930f50ab46d263c0459ce1612eaf9e9e (patch) | |
| tree | 5b51269cf31ad9c61ac19e07a9ac82b7eb6b74fd /board/ampton | |
| parent | 06adaa227002b39cdac8d7c849a0fe15e7ccc8ae (diff) | |
| download | chrome-ec-e56fb445930f50ab46d263c0459ce1612eaf9e9e.tar.gz | |
Ampton: Correct HPD GPIOs
Since ampton is using parade as its USB mux on both ports, both HPD
lines are inputs. This misconfiguration didn't cause any
issues with the EC driving the GPIOs high because they were set as open
drain, but does make it impossible to read the HPD level with "gpioget".
BRANCH=octopus
BUG=None
TEST=on apel, verified that gpioget now returns correct level for HPD
pins when displays are plugged and unplugged
Change-Id: I0ef628cf7ea68884f97a080ba825d780f7feee41
Signed-off-by: Diana Z <dzigterman@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1492853
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Jett Rink <jettrink@chromium.org>
Diffstat (limited to 'board/ampton')
| -rw-r--r-- | board/ampton/gpio.inc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/board/ampton/gpio.inc b/board/ampton/gpio.inc index 359a1a73a6..5e388e8f3e 100644 --- a/board/ampton/gpio.inc +++ b/board/ampton/gpio.inc @@ -94,9 +94,9 @@ GPIO(EN_USB_A0_5V, PIN(B, 7), GPIO_OUT_LOW) /* Enable A0 5V Charging */ GPIO(EN_USB_A1_5V, PIN(H, 3), GPIO_OUT_LOW) /* Enable A1 5V Charging */ GPIO(USB_A0_CHARGE_EN_L, PIN(K, 0), GPIO_OUT_HIGH) /* Enable A0 1.5A Charging */ GPIO(USB_A1_CHARGE_EN_L, PIN(K, 6), GPIO_OUT_HIGH) /* Enable A1 1.5A Charging */ -GPIO(USB_C0_HPD_1V8_ODL, PIN(J, 0), GPIO_ODR_HIGH | +GPIO(USB_C0_HPD_1V8_ODL, PIN(J, 0), GPIO_INPUT | GPIO_SEL_1P8V) /* C0 DP Hotplug Detect */ -GPIO(USB_C1_HPD_1V8_ODL, PIN(J, 1), GPIO_ODR_HIGH | +GPIO(USB_C1_HPD_1V8_ODL, PIN(J, 1), GPIO_INPUT | GPIO_SEL_1P8V) /* C1 DP Hotplug Detect */ GPIO(USB_C0_BC12_CHG_DET_L, PIN(A, 0), GPIO_INPUT) /* C0 BC1.2 Detect */ GPIO(USB_C1_BC12_CHG_DET_L, PIN(I, 0), GPIO_INPUT) /* C1 BC1.2 Detect */ |