diff options
author | Jett Rink <jettrink@chromium.org> | 2019-06-14 14:03:09 -0600 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2019-06-18 02:13:16 +0000 |
commit | 03d1278f03ccbaa8acd08934dcc1ecb48f34356f (patch) | |
tree | f2a0d3a8fda96130afb151fbdb2bf9a57fd91497 /board/arcada_ish | |
parent | 532fab97cca60a70b7baf0fde418e868e0adcf0b (diff) | |
download | chrome-ec-03d1278f03ccbaa8acd08934dcc1ecb48f34356f.tar.gz |
arcada_ish: clean up old comments
The temporary way of handling the power state is actually fine for ISH
long term, so remove TODO comments.
BRANCH=none
BUG=none
TEST=build
Change-Id: I83bbafd0f135329140f39d7790dc8f3e1c8f6463
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1660124
Tested-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
Diffstat (limited to 'board/arcada_ish')
-rw-r--r-- | board/arcada_ish/board.c | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/board/arcada_ish/board.c b/board/arcada_ish/board.c index 01c126aede..be17b2def3 100644 --- a/board/arcada_ish/board.c +++ b/board/arcada_ish/board.c @@ -167,26 +167,27 @@ static void board_init(void) } DECLARE_HOOK(HOOK_INIT, board_init, HOOK_PRIO_DEFAULT); -/* TODO(b/122364080): replace when implement real chipset/power task */ +/* + * The only use for chipset state is sensors, so we hard code the AP state to on + * and make the sensor on in S0. The sensors are always on when the ISH is + * powered. + */ int chipset_in_state(int state_mask) { - /* Until we know better, ISH assumes AP is always ON */ return state_mask & CHIPSET_STATE_ON; } -/* TODO(b/122364080): replace when implement real chipset/power task */ int chipset_in_or_transitioning_to_state(int state_mask) { - /* Until we know better, ISH assumes AP is always ON */ - return state_mask & CHIPSET_STATE_ON; + return chipset_in_state(state_mask); } -/* TODO(b/122364080): replace when implement real chipset/power task */ void chipset_force_shutdown(enum chipset_shutdown_reason reason) { + /* Required, but nothing to do */ } -/* TODO(b/122364080): remove when implement real chipset/power task */ +/* Needed for empty chipset task */ int board_idle_task(void *unused) { while (1) |