diff options
author | Jett Rink <jettrink@chromium.org> | 2019-01-24 11:14:55 -0700 |
---|---|---|
committer | chrome-bot <chrome-bot@chromium.org> | 2019-01-28 14:17:00 -0800 |
commit | 9218e9d4843e9b92d52afa34ec68b2951dde2e2d (patch) | |
tree | 412618e921f441e2c8155a1848b801afa63dfe48 /board/arcada_ish | |
parent | 3925684380e91ef197f91641c72cf569eed9feb5 (diff) | |
download | chrome-ec-9218e9d4843e9b92d52afa34ec68b2951dde2e2d.tar.gz |
arcada: remove gpio lines for I2C
The ISH does not support putting the i2c in manual GPIO mode, so
we should leave SCL and SDA fields on i2c_port_t unset
BRANCH=none
BUG=none
TEST=i2c communications still works
Change-Id: I060d41f97f09e26ceb224249b26308e56abc0da4
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1435480
Reviewed-by: Diana Z <dzigterman@chromium.org>
Diffstat (limited to 'board/arcada_ish')
-rw-r--r-- | board/arcada_ish/board.c | 8 | ||||
-rw-r--r-- | board/arcada_ish/board.h | 2 | ||||
-rw-r--r-- | board/arcada_ish/gpio.inc | 4 |
3 files changed, 6 insertions, 8 deletions
diff --git a/board/arcada_ish/board.c b/board/arcada_ish/board.c index 0225deb370..cd66add92c 100644 --- a/board/arcada_ish/board.c +++ b/board/arcada_ish/board.c @@ -15,8 +15,12 @@ #define CPRINTF(format, args...) cprintf(CC_USBCHARGE, format, ## args) /* I2C port map */ -const struct i2c_port_t i2c_ports[] = { - {"sensor", I2C_PORT_SENSOR, 1000, GPIO_ISH_I2C0_SCL, GPIO_ISH_I2C0_SDA} +const struct i2c_port_t i2c_ports[] = { + { + .name = "sensor", + .port = I2C_PORT_SENSOR, + .kbps = 1000 + }, }; const unsigned int i2c_ports_used = ARRAY_SIZE(i2c_ports); diff --git a/board/arcada_ish/board.h b/board/arcada_ish/board.h index b85d88a37c..ec187cab51 100644 --- a/board/arcada_ish/board.h +++ b/board/arcada_ish/board.h @@ -33,8 +33,6 @@ /* I2C ports */ #define I2C_PORT_SENSOR ISH_I2C0 -#define GPIO_I2C_PORT_TP_SCL GPIO_ISH_I2C0_SCL -#define GPIO_I2C_PORT_TP_SDA GPIO_ISH_I2C0_SDA #define CONFIG_CMD_I2C_XFER /* Undefine features */ diff --git a/board/arcada_ish/gpio.inc b/board/arcada_ish/gpio.inc index ab71f264d5..0ad11eb72c 100644 --- a/board/arcada_ish/gpio.inc +++ b/board/arcada_ish/gpio.inc @@ -9,7 +9,3 @@ * it to be defined. */ UNIMPLEMENTED(ENTERING_RW) - -/* TODO: We do want to fill these in correctly*/ -UNIMPLEMENTED(ISH_I2C0_SDA) -UNIMPLEMENTED(ISH_I2C0_SCL) |