diff options
| author | Philip Chen <philipchen@google.com> | 2019-08-15 18:24:22 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-09-19 03:47:09 +0000 |
| commit | 0beadf2ffd8b23e15d1e7c14de8719d0f45c9519 (patch) | |
| tree | 9b531ef5087e3935542560a4bc9b7cc379c3e843 /board/arcada_ish | |
| parent | 16d2b24ac05f7a5654bddcf9cb61f0f6684d1806 (diff) | |
| download | chrome-ec-0beadf2ffd8b23e15d1e7c14de8719d0f45c9519.tar.gz | |
tablet_mode: Renaming for GMR sensor
GMR sensors can be used to
(1) detect clamshell/tablet mode
(2) detect lid open/closed
But hall sensors can only do (2).
Therefore the naming related to "hall sensor" for tablet mode
application is incorrect.
This patch performs the following renaming to better reflect the reality:
config:
CONFIG_HALL_SENSOR -> CONFIG_GMR_TABLET_MODE
CONFIG_HALL_SENSOR_CUSTOM -> CONFIG_GMR_TABLET_MODE_CUSTOM
CONFIG_DPTF_MOTION_LID_NO_HALL_SENSOR ->
CONFIG_DPTF_MOTION_LID_NO_GMR_SENSOR
GPIO:
HALL_SENSOR_GPIO_L -> GMR_TABLET_MODE_GPIO_L
functions:
hall_sensor_disable() -> gmr_tablet_switch_disable()
hall_sensor_isr() -> gmr_tablet_switch_isr()
hall_sensor_int() -> gmr_tablet_switch_init()
variable:
hall_sensor_at_360 -> gmr_sensor_at_360
BUG=b:139378190
BRANCH=none
TEST=make buildall
Change-Id: I28393d056ddd128d8ffafc16a1f9fefee5455ccc
Signed-off-by: Philip Chen <philipchen@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1757275
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org>
Diffstat (limited to 'board/arcada_ish')
| -rw-r--r-- | board/arcada_ish/board.c | 2 | ||||
| -rw-r--r-- | board/arcada_ish/board.h | 6 | ||||
| -rw-r--r-- | board/arcada_ish/gpio.inc | 2 |
3 files changed, 5 insertions, 5 deletions
diff --git a/board/arcada_ish/board.c b/board/arcada_ish/board.c index 631022aaae..8c96067be5 100644 --- a/board/arcada_ish/board.c +++ b/board/arcada_ish/board.c @@ -156,7 +156,7 @@ int board_sensor_at_360(void) * also active. */ return lid_is_open() && - !gpio_get_level(HALL_SENSOR_GPIO_L); + !gpio_get_level(GMR_TABLET_MODE_GPIO_L); } /* Initialize board. */ diff --git a/board/arcada_ish/board.h b/board/arcada_ish/board.h index f036bfd301..ca69c1ba15 100644 --- a/board/arcada_ish/board.h +++ b/board/arcada_ish/board.h @@ -54,9 +54,9 @@ #define CONFIG_LID_ANGLE_SENSOR_LID LID_ACCEL #define CONFIG_TABLET_MODE -#define CONFIG_HALL_SENSOR -#define CONFIG_HALL_SENSOR_CUSTOM -#define HALL_SENSOR_GPIO_L GPIO_TABLET_MODE_L +#define CONFIG_GMR_TABLET_MODE +#define CONFIG_GMR_TABLET_MODE_CUSTOM +#define GMR_TABLET_MODE_GPIO_L GPIO_TABLET_MODE_L /* DMA paging between SRAM and DRAM */ #define CONFIG_DMA_PAGING diff --git a/board/arcada_ish/gpio.inc b/board/arcada_ish/gpio.inc index 91c25fe632..336f807269 100644 --- a/board/arcada_ish/gpio.inc +++ b/board/arcada_ish/gpio.inc @@ -7,7 +7,7 @@ GPIO_INT(ACCEL_GYRO_INT_L, PIN(0), GPIO_INT_FALLING, lsm6dsm_interrupt) GPIO_INT(LID_OPEN, PIN(5), GPIO_INT_BOTH, lid_interrupt) /* LID_CL_NB_L */ -GPIO_INT(TABLET_MODE_L, PIN(6), GPIO_INT_BOTH, hall_sensor_isr) /* LID_CL_TAB_L */ +GPIO_INT(TABLET_MODE_L, PIN(6), GPIO_INT_BOTH, gmr_tablet_switch_isr) /* LID_CL_TAB_L */ GPIO(NB_MODE_L, PIN(4), GPIO_OUT_LOW) |