diff options
| author | Scott Collyer <scollyer@google.com> | 2021-05-03 09:15:28 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-05-14 16:22:03 +0000 |
| commit | 81bf98de282dcd11287fc8f5a95cc999437e7597 (patch) | |
| tree | 84741f3242937acc2ac37e0500675054ef39e072 /board/baklava | |
| parent | bcc11b209a014da1436e9abb9a6cd2c2918869f5 (diff) | |
| download | chrome-ec-81bf98de282dcd11287fc8f5a95cc999437e7597.tar.gz | |
honeybuns: Board specific power button and LEDs
This CL modifies both power button press/release polairty and power
button LED control signals to be board specific instead of platform
specific.
Previously there were platform specific macros for
BUTTON_PRESSED_LEVEL and BUTTON_RELEASED_LEVEL. But, these levels will
depend on how the power button circuit is designed. This CL moves
these macros to board.h.
In addition, macros are added to for the GPIO signals used for
green/red LED control. This allows for boards that don't support the
power button LED at all.
BUG=b:164157329
BRANCH=quiche
TEST=Verfied power button works on both quiche and
gingerbread. Previously, this was only working on quiche because
gingerbread has opposite polarity for the power button signal. Also,
verfied that power button/status LED turns off when dock is off.
Signed-off-by: Scott Collyer <scollyer@google.com>
Change-Id: Iee838ee158d23252e8b429f51a1dd1a71d8e94a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2868225
Commit-Queue: Scott Collyer <scollyer@chromium.org>
Tested-by: Scott Collyer <scollyer@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Diffstat (limited to 'board/baklava')
| -rw-r--r-- | board/baklava/board.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/board/baklava/board.h b/board/baklava/board.h index 48e8c17866..c5737f8a40 100644 --- a/board/baklava/board.h +++ b/board/baklava/board.h @@ -53,6 +53,9 @@ #define GPIO_USB_HUB_OCP_NOTIFY GPIO_USBC_DATA_OCP_NOTIFY #define GPIO_UFP_PLUG_DET GPIO_MST_UFP_PLUG_DET +#define BUTTON_PRESSED_LEVEL 1 +#define BUTTON_RELEASED_LEVEL 0 + #define GPIO_TRIGGER_1 GPIO_USB3_A5_CDP_EN #define GPIO_TRIGGER_2 GPIO_USB3_A6_CDP_EN |