diff options
| author | wuzhongtian <wuzhongtian@huaqin.corp-partner.google.com> | 2021-05-25 21:36:13 +0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-06-03 04:55:59 +0000 |
| commit | 538e2a55525515998f694c985a59b635a1323671 (patch) | |
| tree | 610b2c84a3b642d8bc04b1b2bc26444a70a29b2a /board/blipper | |
| parent | 300a9a70b84f0e4275c8d18ac2de7857a9888094 (diff) | |
| download | chrome-ec-538e2a55525515998f694c985a59b635a1323671.tar.gz | |
blipper: Optimize EC power consumption
From Blipper HW circuit, some GPIO in EC side is NC or unused.
So, we can configure it as NC to optimize EC power consumption.
1. HDMI_EN_SUB_ODL (GPE0)
2. EC_SUB_IO_1 (GPF0)
3. EC_SUB_IO_1 (GPL3)
4. EC_SUB_ANALOG (GPL0/ADC13)
5. EC_I2C_SENSOR (GPF6/GPF7)
BUG=b:185044041
BRANCH=dedede
TEST=make -j BOARD=blipper
Signed-off-by: Mike Lee <mike5@huaqin.corp-partner.google.com>
Change-Id: I8e04a2ef03fc540a4fc7544ca4ad5b2038ced988
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2918807
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
Diffstat (limited to 'board/blipper')
| -rw-r--r-- | board/blipper/board.c | 10 | ||||
| -rw-r--r-- | board/blipper/board.h | 1 | ||||
| -rw-r--r-- | board/blipper/gpio.inc | 15 |
3 files changed, 8 insertions, 18 deletions
diff --git a/board/blipper/board.c b/board/blipper/board.c index 57e12dd973..1c3ad144b9 100644 --- a/board/blipper/board.c +++ b/board/blipper/board.c @@ -125,13 +125,6 @@ const struct adc_t adc_channels[] = { .shift = 0, .channel = CHIP_ADC_CH3 }, - [ADC_SUB_ANALOG] = { - .name = "SUB_ANALOG", - .factor_mul = ADC_MAX_MVOLT, - .factor_div = ADC_READ_MAX + 1, - .shift = 0, - .channel = CHIP_ADC_CH13 - }, [ADC_TEMP_SENSOR_3] = { .name = "TEMP_SENSOR3", .factor_mul = ADC_MAX_MVOLT, @@ -218,9 +211,6 @@ void board_init(void) gpio_enable_interrupt(GPIO_HDMI_HPD_SUB_ODL); - - gpio_set_level(GPIO_HDMI_EN_SUB_ODL, 0); - /* Set LEDs luminance */ pwm_set_duty(PWM_CH_LED_RED, 70); pwm_set_duty(PWM_CH_LED_GREEN, 70); diff --git a/board/blipper/board.h b/board/blipper/board.h index 0844e843f0..f503c913ac 100644 --- a/board/blipper/board.h +++ b/board/blipper/board.h @@ -87,7 +87,6 @@ enum adc_channel { ADC_VSNS_PP3300_A, /* ADC0 */ ADC_TEMP_SENSOR_1, /* ADC2 */ ADC_TEMP_SENSOR_2, /* ADC3 */ - ADC_SUB_ANALOG, /* ADC13 */ ADC_TEMP_SENSOR_3, /* ADC15 */ ADC_CH_COUNT }; diff --git a/board/blipper/gpio.inc b/board/blipper/gpio.inc index 2f6739b737..c536d55537 100644 --- a/board/blipper/gpio.inc +++ b/board/blipper/gpio.inc @@ -70,8 +70,6 @@ GPIO(EC_I2C_EEPROM_SCL, PIN(B, 3), GPIO_INPUT) GPIO(EC_I2C_EEPROM_SDA, PIN(B, 4), GPIO_INPUT) GPIO(EC_I2C_BATTERY_SCL, PIN(C, 1), GPIO_INPUT) GPIO(EC_I2C_BATTERY_SDA, PIN(C, 2), GPIO_INPUT) -GPIO(EC_I2C_SENSOR_SCL, PIN(F, 6), GPIO_INPUT | GPIO_SEL_1P8V) -GPIO(EC_I2C_SENSOR_SDA, PIN(F, 7), GPIO_INPUT | GPIO_SEL_1P8V) GPIO(EC_I2C_USB_C0_SCL, PIN(A, 4), GPIO_INPUT) GPIO(EC_I2C_USB_C0_SDA, PIN(A, 5), GPIO_INPUT) @@ -81,14 +79,12 @@ GPIO(EN_USB_A1_VBUS, PIN(E, 6), GPIO_OUT_LOW) GPIO(EC_AP_USB_C0_HPD, PIN(L, 4), GPIO_OUT_LOW) GPIO(EC_AP_USB_C1_HDMI_HPD, PIN(K, 7), GPIO_OUT_LOW) GPIO(HDMI_SEL_L, PIN(C, 6), GPIO_OUT_LOW) -GPIO(HDMI_EN_SUB_ODL, PIN(E, 0), GPIO_OUT_HIGH) /* MKBP event synchronization */ GPIO(EC_AP_MKBP_INT_L, PIN(L, 5), GPIO_ODR_HIGH) /* Misc pins which will run to the I/O board */ -GPIO(EC_SUB_IO_1_1, PIN(L, 3), GPIO_INPUT) -GPIO(EC_SUB_IO_1_2, PIN(F, 0), GPIO_INPUT) + /* Misc */ GPIO(EN_BL_OD, PIN(K, 4), GPIO_ODR_LOW) @@ -106,9 +102,13 @@ GPIO(GPIOB5_NC, PIN(B, 5), GPIO_INPUT | GPIO_PULL_DOWN) GPIO(GPIOC0_NC, PIN(C, 0), GPIO_INPUT | GPIO_PULL_DOWN) GPIO(GPIOC3_NC, PIN(C, 3), GPIO_INPUT | GPIO_PULL_DOWN) GPIO(GPIOC4_NC, PIN(C, 4), GPIO_INPUT | GPIO_PULL_DOWN) +GPIO(GPIOE0_NC, PIN(E, 0), GPIO_INPUT | GPIO_PULL_DOWN) +GPIO(GPIOF0_NC, PIN(F, 0), GPIO_INPUT | GPIO_PULL_DOWN) GPIO(GPIOF1_NC, PIN(F, 1), GPIO_INPUT | GPIO_PULL_DOWN) GPIO(GPIOF4_NC, PIN(F, 4), GPIO_INPUT | GPIO_PULL_DOWN) GPIO(GPIOF5_NC, PIN(F, 5), GPIO_INPUT | GPIO_PULL_DOWN) +GPIO(GPIOF6_NC, PIN(F, 6), GPIO_INPUT | GPIO_PULL_DOWN) +GPIO(GPIOF7_NC, PIN(F, 7), GPIO_INPUT | GPIO_PULL_DOWN) GPIO(GPIOG3_NC, PIN(G, 3), GPIO_INPUT | GPIO_PULL_DOWN) GPIO(GPIOG4_NC, PIN(G, 4), GPIO_INPUT | GPIO_PULL_DOWN) GPIO(GPIOG5_NC, PIN(G, 5), GPIO_INPUT | GPIO_PULL_DOWN) @@ -125,6 +125,8 @@ GPIO(GPIOJ3_NC, PIN(J, 3), GPIO_INPUT | GPIO_PULL_DOWN) GPIO(GPIOJ4_NC, PIN(J, 4), GPIO_INPUT | GPIO_PULL_DOWN) GPIO(GPIOJ5_NC, PIN(J, 5), GPIO_INPUT | GPIO_PULL_DOWN) GPIO(GPIOJ6_NC, PIN(J, 6), GPIO_INPUT | GPIO_PULL_DOWN) +GPIO(GPIOL0_NC, PIN(L, 0), GPIO_INPUT | GPIO_PULL_DOWN) +GPIO(GPIOL3_NC, PIN(L, 3), GPIO_INPUT | GPIO_PULL_DOWN) GPIO(GPIOM6_NC, PIN(M, 6), GPIO_INPUT | GPIO_PULL_DOWN) /* Alternate functions GPIO definitions */ @@ -134,11 +136,10 @@ ALTERNATE(PIN_MASK(B, BIT(0) | BIT(1)), 0, MODULE_UART, 0) /* UART for debug */ /* I2C */ ALTERNATE(PIN_MASK(B, BIT(3) | BIT(4)), 0, MODULE_I2C, 0) /* I2C0 */ ALTERNATE(PIN_MASK(C, BIT(1) | BIT(2)), 0, MODULE_I2C, 0) /* I2C1 */ -ALTERNATE(PIN_MASK(F, BIT(6) | BIT(7)), 0, MODULE_I2C, GPIO_SEL_1P8V) /* I2C2 - 1.8V */ ALTERNATE(PIN_MASK(A, BIT(4) | BIT(5)), 0, MODULE_I2C, 0) /* I2C5 */ /* ADC */ -ALTERNATE(PIN_MASK(L, BIT(0) | BIT(2)), 0, MODULE_ADC, 0) /* ADC13: EC_SUB_ANALOG, ADC15: TEMP_SENSOR_3 */ +ALTERNATE(PIN_MASK(L, BIT(2)), 0, MODULE_ADC, 0) /* ADC15: TEMP_SENSOR_3 */ ALTERNATE(PIN_MASK(I, BIT(0) | BIT(2) | BIT(3)), 0, MODULE_ADC, 0) /* ADC0: EC_VSNS_PP3300_A, ADC2: TEMP_SENSOR_1, ADC3: TEMP_SENSOR_2 */ /* DAC */ |