diff options
| author | jerry2.huang <jerry2.huang@lcfc.corp-partner.google.com> | 2020-12-25 20:53:56 +0800 |
|---|---|---|
| committer | Justin TerAvest <teravest@chromium.org> | 2020-12-28 22:49:16 +0000 |
| commit | 02bcfba2c3e1aa4ac71a234314477cd5b2758dea (patch) | |
| tree | 78dcdbe6078ef1962e2f9672515f4ff9d5fc2990 /board/boten | |
| parent | ec792c5ee08e3ddf55ba0b55c4cea22e3a3f8308 (diff) | |
| download | chrome-ec-02bcfba2c3e1aa4ac71a234314477cd5b2758dea.tar.gz | |
Boten: Correct EN_BL_OD gpio attribute
1. EN_BL_OD should be configured as Open Drain, not Push Pull because
this gpio has external pull up.
2. In failure condition, EC configure it as Push Pull, and its power
leakage, pass to Panel, across CPU, then to PP3300_A.
3. EC monitor PP3300_A power rail by EC_VSNS_PP3300_A, and base on it to
control EC_AP_DPWROK.
4. Due to incorrect voltage level, and cause wrong power-off state.
BUG=b:174798347
BRANCH=dedede
TEST=make buildall, verify panel power leakage pass
Signed-off-by: jerry2.huang <jerry2.huang@lcfc.corp-partner.google.com>
Change-Id: I54ab12b8a74996d859b963e59568b706da36a729
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2603093
Reviewed-by: Justin TerAvest <teravest@chromium.org>
Commit-Queue: Justin TerAvest <teravest@chromium.org>
Tested-by: Justin TerAvest <teravest@chromium.org>
Diffstat (limited to 'board/boten')
| -rw-r--r-- | board/boten/gpio.inc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/board/boten/gpio.inc b/board/boten/gpio.inc index a159a38940..2e5c76aed5 100644 --- a/board/boten/gpio.inc +++ b/board/boten/gpio.inc @@ -95,7 +95,7 @@ GPIO(EC_SUB_IO_1_1, PIN(L, 3), GPIO_INPUT) GPIO(EC_SUB_IO_1_2, PIN(F, 0), GPIO_INPUT) /* Misc */ -GPIO(EN_BL_OD, PIN(K, 4), GPIO_OUT_LOW) +GPIO(EN_BL_OD, PIN(K, 4), GPIO_ODR_LOW) GPIO(EC_ENTERING_RW, PIN(G, 0), GPIO_OUT_LOW) GPIO(CCD_MODE_ODL, PIN(H, 5), GPIO_INPUT) GPIO(EC_BATTERY_PRES_ODL, PIN(I, 4), GPIO_INPUT) |