diff options
| author | Jonathan Brandmeyer <jbrandmeyer@chromium.org> | 2018-06-26 15:40:14 -0600 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-06-28 12:47:06 -0700 |
| commit | b6f2187bb736cdbebc369de54aa749cd1775e719 (patch) | |
| tree | 1cc865fd07614cd82c993fd9a04d6d430a8a19ac /board/careena/gpio.inc | |
| parent | d3d32401605e7fb4957eef4f324a2bd93e9eb624 (diff) | |
| download | chrome-ec-b6f2187bb736cdbebc369de54aa749cd1775e719.tar.gz | |
careena, grunt: Enable pullup for the lid switch.
In the case that the lid switch becomes loose/disconnected, default to
the 'lid open' state by pulling up the GPIO. Grunt is not affected, but
we want to demonstrate best practices for the grunt family with its
configuration.
BUG=b:110836185
BRANCH=none
TEST=disconnected lid switch on careena and observed lid state remained
open and stable. Reconnected lid switch and observed lid state followed
physical lid position.
Change-Id: I951594ed7f6d98cf1b5258a894d0b95b6ca98ecc
Signed-off-by: Jonathan Brandmeyer <jbrandmeyer@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1115859
Commit-Ready: Martin Roth <martinroth@chromium.org>
Reviewed-by: Edward Hill <ecgh@chromium.org>
Reviewed-by: Martin Roth <martinroth@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>
Diffstat (limited to 'board/careena/gpio.inc')
| -rw-r--r-- | board/careena/gpio.inc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/board/careena/gpio.inc b/board/careena/gpio.inc index 58a57d5249..7cbab93b39 100644 --- a/board/careena/gpio.inc +++ b/board/careena/gpio.inc @@ -17,7 +17,7 @@ GPIO_INT(PCH_SLP_S5_L, PIN(A, 3), GPIO_INT_BOTH, power_signal_interrupt) GPIO_INT(S0_PGOOD, PIN(F, 4), GPIO_INT_BOTH, power_signal_interrupt) GPIO_INT(S5_PGOOD, PIN(6, 3), GPIO_INT_BOTH | GPIO_PULL_UP, power_signal_interrupt) GPIO_INT(POWER_BUTTON_L, PIN(0, 1), GPIO_INT_BOTH, power_button_interrupt) -GPIO_INT(LID_OPEN, PIN(D, 2), GPIO_INT_BOTH | GPIO_HIB_WAKE_HIGH, lid_interrupt) +GPIO_INT(LID_OPEN, PIN(D, 2), GPIO_INT_BOTH | GPIO_HIB_WAKE_HIGH | GPIO_PULL_UP, lid_interrupt) GPIO_INT(AC_PRESENT, PIN(0, 0), GPIO_INT_BOTH | GPIO_HIB_WAKE_HIGH, extpower_interrupt) GPIO_INT(WP_L, PIN(A, 1), GPIO_INT_BOTH, switch_interrupt) GPIO_INT(VOLUME_DOWN_L, PIN(7, 0), GPIO_INT_BOTH | GPIO_PULL_UP, button_interrupt) |