diff options
| author | Wai-Hong Tam <waihong@google.com> | 2020-10-13 16:38:25 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-10-20 03:45:41 +0000 |
| commit | e882e9482e112f2f6594d8f278467aac865f28a2 (patch) | |
| tree | 4611c73a6efde4f960ebedfe3541cfd58a2ad4f2 /board/coachz | |
| parent | 8fe20badace309555a35ba3372a9947ba0918e78 (diff) | |
| download | chrome-ec-e882e9482e112f2f6594d8f278467aac865f28a2.tar.gz | |
Trogdor: Enable pull-down on SHI signals
Enable pull-down to avoid these signals floating. It is believed that
it can get better power number in S5/G3.
BRANCH=None
BUG=b:169595541
TEST=Host commands between EC and AP work as expected. Check the GPIOs
are low when AP is off.
Change-Id: I1bcf882bf8f29b06a129700faebee8552085f0ef
Signed-off-by: Wai-Hong Tam <waihong@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2469505
Reviewed-by: Alexandru M Stan <amstan@chromium.org>
Diffstat (limited to 'board/coachz')
| -rw-r--r-- | board/coachz/gpio.inc | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/board/coachz/gpio.inc b/board/coachz/gpio.inc index 80a9e59b1c..db7c68d743 100644 --- a/board/coachz/gpio.inc +++ b/board/coachz/gpio.inc @@ -99,6 +99,15 @@ GPIO(USB_A_CDP_ILIM_EN, PIN(7, 5), GPIO_INPUT) /* NC, backup only */ GPIO(EC_CHG_LED_Y_C0, PIN(C, 3), GPIO_OUT_LOW) GPIO(EC_CHG_LED_W_C0, PIN(C, 4), GPIO_OUT_LOW) +/* + * SPI host interface - enable PDs by default. These will be made functional + * by the SHI driver when the AP powers up, and restored back to GPIO when + * the AP powers down. + */ +GPIO(AP_EC_SPI_MOSI, PIN(4, 6), GPIO_INPUT | GPIO_PULL_DOWN) +GPIO(AP_EC_SPI_MISO, PIN(4, 7), GPIO_INPUT | GPIO_PULL_DOWN) +GPIO(AP_EC_SPI_CLK, PIN(5, 5), GPIO_INPUT | GPIO_PULL_DOWN) + /* PWM */ GPIO(EDP_BKLTCTL, PIN(B, 7), GPIO_INPUT) /* PWM5 */ |