diff options
| author | Daisuke Nojiri <dnojiri@chromium.org> | 2021-01-21 10:16:13 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-01-28 20:52:06 +0000 |
| commit | 48c97bf65ca421ce5036a73831da644f0298b7ff (patch) | |
| tree | f2cbdc7159f778d510d6ead52bd66dddebd055f7 /board/coachz | |
| parent | ef04b4715db47812e3e2cdaf083a1a3118c511b5 (diff) | |
| download | chrome-ec-48c97bf65ca421ce5036a73831da644f0298b7ff.tar.gz | |
CoachZ: Pull down WLC IRQ
ctn730 push-pulls the IRQ line. When it's off, the line should stay
low to prevent the EC from getting false IRQ.
This patch also configures the ctn730 reset line as GPIO_ODR_HIGH so
that the line is kept high and a reset can be issued if needed.
BUG=b:173235954, b:178096436
BRANCH=trogdor
TEST=CoachZ. Verified reset line goes up and down by gpioset.
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Change-Id: I0023d9a980826a6ea4741459a0b65c2cc11e6106
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2656766
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
Diffstat (limited to 'board/coachz')
| -rw-r--r-- | board/coachz/gpio.inc | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/board/coachz/gpio.inc b/board/coachz/gpio.inc index 045060c3d8..e84c690f55 100644 --- a/board/coachz/gpio.inc +++ b/board/coachz/gpio.inc @@ -29,8 +29,8 @@ GPIO_INT(PS_HOLD, PIN(A, 4), GPIO_INT_BOTH | GPIO_PULL_DOWN, power_sig GPIO_INT(AP_SUSPEND, PIN(5, 7), GPIO_INT_BOTH, power_signal_interrupt) /* Suspend signal from PMIC */ GPIO_INT(DEPRECATED_AP_RST_REQ, PIN(C, 2), GPIO_INT_BOTH | GPIO_PULL_DOWN | GPIO_SEL_1P8V, power_signal_interrupt) /* Deprecated AP initiated reset indicator */ -/* WLC interrupt */ -GPIO_INT(WLC_IRQ_CONN, PIN(7, 4), GPIO_INT_RISING, pchg_irq) +/* WLC interrupt. GPIO_PULL_DOWN ensures no IRQ when WLC chip is off. */ +GPIO_INT(WLC_IRQ_CONN, PIN(7, 4), GPIO_INT_RISING | GPIO_PULL_DOWN, pchg_irq) /* * When switch-cap is off, the POWER_GOOD signal is floating. Need a pull-down @@ -74,9 +74,8 @@ GPIO(EC_BL_DISABLE_L, PIN(B, 6), GPIO_OUT_LOW) /* Backlight disable sign /* TODO(waihong): Should remove it from hardware */ GPIO(CAM_LED, PIN(3, 0), GPIO_INPUT) -/* Stylus */ -/* TODO(b/168652326): Implement the WLC controls */ -GPIO(WLC_NRST_CONN, PIN(C, 5), GPIO_INPUT) +/* Reset line for WLC. External pull-up is expected. */ +GPIO(WLC_NRST_CONN, PIN(C, 5), GPIO_ODR_HIGH) /* Base detection */ GPIO(EN_BASE, PIN(0, 4), GPIO_OUT_LOW) /* Enable power to detachable base */ |