diff options
| author | Ting Shen <phoenixshen@google.com> | 2021-05-04 17:24:13 +0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-05-12 06:06:58 +0000 |
| commit | 34250aff259c509af0b4d9ff58c09835084eac53 (patch) | |
| tree | 8ec6737c8c73a070041e0ec216a9bad8e11a4094 /board/collis | |
| parent | c006d7837d47811d948523f90a9867144cd8348a (diff) | |
| download | chrome-ec-34250aff259c509af0b4d9ff58c09835084eac53.tar.gz | |
anx3443: fix incorrect set_mux implementation
Current driver code sets 0xF8 bit [1:0] to 0b00 when USB_PD_MUX_NONE.
However, according to the programming guide (b/181282482#comment3).
0b00 means "power-off", not "disable both paths".
This is not what we want because power-off mode blocks all subsequent
i2c transactions.
Since this mux does not have a "none" state, this CL maps
USB_PD_MUX_NONE to USB enabled instead.
BUG=b:181282482
TEST=Boot Cherry, verify that error messages like
"mux config:0, port:1, rv:1" disappeared
BRANCH=main
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: I2c87c839242fa61e4ba0e1dfca54ebe5bb3beb37
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2870537
Reviewed-by: Eric Yilun Lin <yllin@google.com>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
Diffstat (limited to 'board/collis')
0 files changed, 0 insertions, 0 deletions