summaryrefslogtreecommitdiff
path: root/board/coral/board.c
diff options
context:
space:
mode:
authorDiana Z <dzigterman@chromium.org>2018-11-08 11:02:22 -0700
committerchrome-bot <chrome-bot@chromium.org>2018-11-13 16:26:21 -0800
commitb072948de622962e77c03f0a1853432dc6633626 (patch)
tree604374f7e8e6ed3f1aeca32377488ddec5271f13 /board/coral/board.c
parent40b8b2bc6ffb9103c60f8fe89c9c3eebf899a0e8 (diff)
downloadchrome-ec-b072948de622962e77c03f0a1853432dc6633626.tar.gz
SN5S330: treat interrupts as level-sensitive
The SN5S330 PPC will pull its /INT pin low until all interrupts are cleared. Since the interrupt pin is treated as edge-sensitive, its handler needs to provide level-checking before exiting. Otherwise, if not all interrupts are cleared before the handler exits, the EC won't see another edge to call the handler again. Boards which share the PPC interrupt pin with other sources may choose to implement their own callback, if they are able to determine which chip was the source of the interrupt. BUG=b:118846062 BRANCH=None TEST=performed several power swaps and unplugs on a pair of Careenas, verifying that in instances where the handler had to loop around we correctly cleared the interrupts and the "ectool usbpdpower" output was normal Change-Id: Iccbe40976a746d109d67b9a91f8fbd81898f9b3f Signed-off-by: Diana Z <dzigterman@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1327123 Reviewed-by: Scott Collyer <scollyer@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org>
Diffstat (limited to 'board/coral/board.c')
0 files changed, 0 insertions, 0 deletions