diff options
| author | Shawn Nematbakhsh <shawnn@chromium.org> | 2018-01-23 10:08:53 -0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-01-30 14:54:23 -0800 |
| commit | 9afcd8d602e3db10992866cbd52a303fbd77cc4b (patch) | |
| tree | e7e484e6283b5ae68353eca6864e5d69290bb731 /board/coral | |
| parent | 1c90656d03a2d28392515e374681dce4698ca881 (diff) | |
| download | chrome-ec-9afcd8d602e3db10992866cbd52a303fbd77cc4b.tar.gz | |
cleanup: Remove CONFIG_USB_PD_TCPC_BOARD_INIT
It's no longer necessary to call board_tcpc_init() from PD tasks, since
HOOK_INIT completion is guaranteed before the task starts. Also, calling
board_tcpc_init() for each PD task without a port arg is a bad idea.
BUG=b:72229154
BRANCH=none
TEST=`make buildall -j`
Change-Id: I6fba07771693b8343568041960a263e02775a8fc
Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/881538
Commit-Ready: Shawn N <shawnn@chromium.org>
Tested-by: Shawn N <shawnn@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Edward Hill <ecgh@chromium.org>
Diffstat (limited to 'board/coral')
| -rw-r--r-- | board/coral/board.c | 3 | ||||
| -rw-r--r-- | board/coral/board.h | 1 |
2 files changed, 2 insertions, 2 deletions
diff --git a/board/coral/board.c b/board/coral/board.c index 7a36855c5c..1b0a8044c3 100644 --- a/board/coral/board.c +++ b/board/coral/board.c @@ -362,7 +362,7 @@ void board_reset_pd_mcu(void) board_set_tcpc_power_mode(USB_PD_PORT_ANX74XX, 1); } -void board_tcpc_init(void) +static void board_tcpc_init(void) { int port, reg; int count = 0; @@ -411,6 +411,7 @@ void board_tcpc_init(void) mux->hpd_update(port, 0, 0); } } +DECLARE_HOOK(HOOK_INIT, board_tcpc_init, HOOK_PRIO_DEFAULT); /* * Data derived from Seinhart-Hart equation in a resistor divider circuit with diff --git a/board/coral/board.h b/board/coral/board.h index b73770f6dc..121ff1a0a0 100644 --- a/board/coral/board.h +++ b/board/coral/board.h @@ -321,7 +321,6 @@ void board_reset_pd_mcu(void); int board_get_version(void); void board_set_tcpc_power_mode(int port, int mode); -void board_tcpc_init(void); /* Sensors without hardware FIFO are in forced mode */ #define CONFIG_ACCEL_FORCE_MODE_MASK (1 << LID_ACCEL) |