diff options
| author | Mary Ruthven <mruthven@google.com> | 2018-10-15 17:32:05 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-04-05 03:53:05 -0700 |
| commit | 9d09e1f04007c3fef98d35e5514fcaa2fea237ce (patch) | |
| tree | 9b40d1da148a125dffdad6e7701ebb4cccc3ecc5 /board/cr50/board.h | |
| parent | c0814644b003412ac81b83068028749fe8a0ae76 (diff) | |
| download | chrome-ec-9d09e1f04007c3fef98d35e5514fcaa2fea237ce.tar.gz | |
cr50: make sys_rst_l_out pseudo open drain
The existing SYS_RST_L implementation enables the output on SYS_RST_L
before setting the level to 0, which results in cr50 briefly driving
SYS_RST_L high when SYS_RST_L is asserted. This patch switches SYS_RST_L
to a pseudo open drain mode, which eliminates the pulse.
The internal pull up on SYS_RST_L is not being removed, so the H1 will
still pull this line up when SYS_RST_L output is set to 1. Removing the
pull up will require careful analysis of existing designs, and if safe
will be done in a different patch.
BUG=b:117676461
BRANCH=cr50
TEST=assert/deassert sys_rst_l and check that 'sysrst' shows the correct
state. Verify this works on cheza which only pulls SYS_RST_L up to 1.8V
even though VDDIOM is 3.3V.
Change-Id: I50c9569e70c97cec434df3095f1b109f3248076b
Signed-off-by: Mary Ruthven <mruthven@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1282020
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
Diffstat (limited to 'board/cr50/board.h')
| -rw-r--r-- | board/cr50/board.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/board/cr50/board.h b/board/cr50/board.h index 78f6d5915a..272ec813ff 100644 --- a/board/cr50/board.h +++ b/board/cr50/board.h @@ -38,6 +38,9 @@ #undef CONFIG_FLASH #endif +/* Enable getting gpio flags to tell if open drain pins are asserted */ +#define CONFIG_GPIO_GET_EXTENDED + /* Flash configuration */ #undef CONFIG_FLASH_PSTATE #define CONFIG_WP_ALWAYS |