diff options
| author | Mary Ruthven <mruthven@chromium.org> | 2018-05-16 20:01:29 +0000 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-05-17 19:34:46 -0700 |
| commit | 2ca73981809debeeb3112c09b939de6b56514b5d (patch) | |
| tree | c8ee59f8387060aa26239571adc0c2aee0563295 /board/cr50/board.h | |
| parent | c00edb39a0722fbf9af972f3bc3e931889c40185 (diff) | |
| download | chrome-ec-2ca73981809debeeb3112c09b939de6b56514b5d.tar.gz | |
Revert "cr50: add support for enabling terminations on ap suspend"
This reverts commit cfcac78e626ce08ccc1c45c91c61127b6088e80f.
Reason for revert: Removing all s3 termination support. It's not
necessary and it causes scarlet to boot into recovery.
Original change's description:
> cr50: add support for enabling terminations on ap suspend
>
> rk3399 systems need terminations on the SPI signals in S3 and all other
> low power states. Add support for enabling the pulldowns and pullups on
> the correct pins.
>
> With this change, if BOARD_NEEDS_S3_TERM is set in the board properties,
> cr50 will enable a pulldown on the AP TX Cr50 RX signal and a pulldown
> on all of the SPS signals. To keep the pulldowns from interfering with
> the sps peripheral, s3_term will also disable the input for those
> signals.
>
> BUG=b:62200096
> BRANCH=cr50
> TEST=Flash onto bob. Make sure cr50 enables and disables terminations
> when the AP suspends/resumes. Flash onto reef. Make sure it doesn't do
> anything.
>
> Change-Id: I4adaf6d66160bab1eb3cf3d343d4a79524ccf883
> Signed-off-by: Mary Ruthven <mruthven@google.com>
> Reviewed-on: https://chromium-review.googlesource.com/991338
> Commit-Ready: Mary Ruthven <mruthven@chromium.org>
> Tested-by: Mary Ruthven <mruthven@chromium.org>
> Reviewed-by: Randall Spangler <rspangler@chromium.org>
Bug: b:62200096
Change-Id: I00c5051a48d4578badf9ce6622dea1af9903f4fd
Reviewed-on: https://chromium-review.googlesource.com/1062687
Commit-Ready: Mary Ruthven <mruthven@chromium.org>
Tested-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
Diffstat (limited to 'board/cr50/board.h')
| -rw-r--r-- | board/cr50/board.h | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/board/cr50/board.h b/board/cr50/board.h index 92c4230620..cf179d5d11 100644 --- a/board/cr50/board.h +++ b/board/cr50/board.h @@ -262,9 +262,6 @@ int board_tpm_uses_spi(void); int board_id_is_mismatched(void); /* Allow for deep sleep to be enabled on AP shutdown */ int board_deep_sleep_allowed(void); -int board_needs_s3_term(void); -int board_s3_term_is_enabled(void); -void board_s3_term(int enable); void power_button_record(void); @@ -285,7 +282,6 @@ void print_servo_state(void); int ap_is_on(void); int ap_uart_is_on(void); -int ap_is_suspended(void); int ec_is_on(void); int ec_is_rx_allowed(void); int servo_is_connected(void); |