ap RO verification: enable logging

When AP RO verification is attempted, a lot of thing could go wrong,
and the operator would usually have very little insight into what's
happening unless there is a terminal connected to the Cr50 console.

This patch adds a new log event for registering the AP RO verification
progress. The event payload is a single byte value, logging the
following events:

  0 - refresh key press is detected
  1 - power button has been released before AP RO check was triggered
  2 - trigger sequence timeout (refresh button not pressed in time)
  3 - AP RO check triggered
  4 - could not run the check, hash space not programmed
  5 - could not run the check, hash space corrupted
  6 - AP RO verification failed
  7 - AP RO verification succeeded

BUG=b:153764696
TEST=verified logging during various AP RO verification attempts:
    $ gsctool -a -L
    Log time zone is PST
    Dec 31 69 16:00:01 : 00
    May 06 20 21:20:49 : 09 01
    May 06 20 21:21:53 : 09 00
    May 06 20 21:21:54 : 09 00
    May 06 20 21:21:55 : 09 03
    May 06 20 21:21:56 : 09 07
    May 06 20 21:23:03 : 09 00
    May 06 20 21:23:04 : 09 00
    May 06 20 21:23:05 : 09 02
    May 07 20 11:21:52 : 09 00
    May 07 20 11:21:53 : 09 00
    May 07 20 11:21:54 : 09 01
    May 08 20 11:57:21 : 09 00
    May 08 20 11:57:22 : 09 00
    May 08 20 11:57:23 : 09 03
    May 08 20 11:57:24 : 09 04
    May 08 20 12:07:15 : 09 00
    May 08 20 12:07:16 : 09 00
    May 08 20 12:07:17 : 09 03
    May 08 20 12:07:19 : 09 07
    May 08 20 12:09:20 : 09 00
    May 08 20 12:09:21 : 09 00
    May 08 20 12:09:22 : 09 03
    May 08 20 12:09:23 : 09 06

Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Change-Id: I739f9dbb2e7b8fc87601d61e1f87eb49d85bdf14
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2191283
Reviewed-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-by: Namyoon Woo <namyoon@chromium.org>

1 files changed, 19 insertions, 2 deletions

diff --git a/board/cr50/power_button.c b/board/cr50/power_button.c
index bff6c4890c..6aca820caf 100644
--- a/board/cr50/power_button.c
+++ b/board/cr50/power_button.c
@@ -119,14 +119,29 @@ static int rctd_poll_handler(void)
 	} else {
 		/* Have this been running longer than the timeout? */
 		if ((get_time().le.lo - rctd_start_time) > RCTD_CUTOFF_TIME) {
-			CPRINTS("Timeout, no RO check triggered");
+			if (ref_press_count) {
+				/*
+				 * Report timeout only in case the process
+				 * started.
+				 */
+				ap_ro_add_flash_event(APROF_CHECK_TIMED_OUT);
+				CPRINTS("Timeout, no RO check triggered");
+			}
 			return 0;
 		}
 	}
 
 
 	if ((dior_state & GC_RBOX_CHECK_INPUT_PWRB_IN_MASK) != 0) {
-		CPRINTS("Power button released, RO Check Detection stopped");
+		if (ref_press_count) {
+			/*
+			 * Report interruption only in case the process
+			 * started.
+			 */
+			CPRINTS("Power button released, "
+				"RO Check Detection stopped");
+			ap_ro_add_flash_event(APROF_CHECK_STOPPED);
+		}
 		return 0;
 	}
 
@@ -147,11 +162,13 @@ static int rctd_poll_handler(void)
 		return 1;
 
 	if (++ref_press_count != PRESS_COUNT) {
+		ap_ro_add_flash_event(APROF_REFRESH_PRESSED);
 		CPRINTS("Refresh press registered");
 		return 1;
 	}
 
 	CPRINTS("RO Validation triggered");
+	ap_ro_add_flash_event(APROF_CHECK_TRIGGERED);
 	validate_ap_ro();
 	return 0;
 }