diff options
| author | Vadim Sukhomlinov <sukhomlinov@google.com> | 2021-12-28 07:22:29 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-12-28 16:40:22 +0000 |
| commit | eb0ed7b4e255646577d19fdb6c1643c5a55f020d (patch) | |
| tree | 0db91cb1c91e520393f7dbac92b1fb8b0bc8e66f /board/cr50 | |
| parent | 646aedf8ea12fb324c40e87e42a668318b3307b9 (diff) | |
| download | chrome-ec-eb0ed7b4e255646577d19fdb6c1643c5a55f020d.tar.gz | |
cr50: fix g2f certificate retrieval
Logical error was introduced in crrev.com/c/3119223 which resulted in
failing attempts to read G2F certificate from virtual nvmem.
This CL fixes it and adds a test for this command.
BUG=b:211820657
TEST=make BOARD=cr50; test/tpm_test/tpm_test.py
Signed-off-by: Vadim Sukhomlinov <sukhomlinov@google.com>
Change-Id: I3c46e9e050d5084dbac1b0a7c3d7e378987a3759
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3359755
Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
Tested-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
Reviewed-by: Mary Ruthven <mruthven@chromium.org>
Commit-Queue: Vadim Sukhomlinov <sukhomlinov@chromium.org>
Diffstat (limited to 'board/cr50')
| -rw-r--r-- | board/cr50/dcrypto/u2f.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/board/cr50/dcrypto/u2f.c b/board/cr50/dcrypto/u2f.c index 6680007a44..2496370c60 100644 --- a/board/cr50/dcrypto/u2f.c +++ b/board/cr50/dcrypto/u2f.c @@ -589,7 +589,7 @@ size_t g2f_attestation_cert_serial(const struct u2f_state *state, { p256_int d, pk_x, pk_y; - if (g2f_individual_key_pair(state, &d, &pk_x, &pk_y)) + if (!g2f_individual_key_pair(state, &d, &pk_x, &pk_y)) return 0; /* Note that max length is not currently respected here. */ |