diff options
| author | Denis Brockus <dbrockus@google.com> | 2020-06-30 12:42:04 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-07-01 23:35:52 +0000 |
| commit | dc3e8d69dbffc330a0725eacf00da14f54ac86fc (patch) | |
| tree | 30d440d51929310a4936a36c9b0cd50463f561cd /board/dalboz | |
| parent | e8bd3c057ceb1c881ccd5112b577d94cd730b7d6 (diff) | |
| download | chrome-ec-dc3e8d69dbffc330a0725eacf00da14f54ac86fc.tar.gz | |
TCPMv2: make sure Vbus is not sourced in AttachWait.SRC
The TCPC on zork appears to enable Vbus sourcing some
of the time when we come out of auto-toggle. It looks
like about a 60ms delay before it is enabled. We then
go to AttachWait.SRC and since the exit condition to
get to Attached.SRC is a debounced/valid Attached.SRC
CC and Safe0V, it has to be disabled manually in order
to move to Attached.SRC
BUG=b:160227699,b:160253746
BRANCH=none
TEST=dut-control servo_v4_role:snk should attach
Signed-off-by: Denis Brockus <dbrockus@google.com>
Change-Id: I1dfc5d2536aaa4d7a5ffc7bbb52c647b15764196
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2276463
Tested-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
Auto-Submit: Denis Brockus <dbrockus@chromium.org>
Diffstat (limited to 'board/dalboz')
| -rw-r--r-- | board/dalboz/board.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/board/dalboz/board.c b/board/dalboz/board.c index b2e5606a4e..0ec09e8b72 100644 --- a/board/dalboz/board.c +++ b/board/dalboz/board.c @@ -384,7 +384,8 @@ const struct tcpc_config_t tcpc_config[] = { .addr_flags = NCT38XX_I2C_ADDR1_1_FLAGS, }, .drv = &nct38xx_tcpm_drv, - .flags = TCPC_FLAGS_TCPCI_REV2_0, + .flags = TCPC_FLAGS_TCPCI_REV2_0 | + TCPC_FLAGS_TCPCI_BAD_VBUS_SOURCING, }, [USBC_PORT_C1] = { .bus_type = EC_BUS_TYPE_I2C, @@ -393,7 +394,8 @@ const struct tcpc_config_t tcpc_config[] = { .addr_flags = NCT38XX_I2C_ADDR1_1_FLAGS, }, .drv = &nct38xx_tcpm_drv, - .flags = TCPC_FLAGS_TCPCI_REV2_0, + .flags = TCPC_FLAGS_TCPCI_REV2_0 | + TCPC_FLAGS_TCPCI_BAD_VBUS_SOURCING, }, }; BUILD_ASSERT(ARRAY_SIZE(tcpc_config) == USBC_PORT_COUNT); |