summaryrefslogtreecommitdiff
path: root/board/dooly
diff options
context:
space:
mode:
authorGwendal Grignou <gwendal@chromium.org>2021-03-01 09:56:59 -0800
committerCommit Bot <commit-bot@chromium.org>2021-03-02 03:10:31 +0000
commitc104ea6ed92dd98a76c0de6332d9b1697a3eeeb6 (patch)
treea7e3bc296b114779db8c06818ed8cc49dde08311 /board/dooly
parent063839556ea54fd89273e825cf806fbbfb0a6254 (diff)
downloadchrome-ec-c104ea6ed92dd98a76c0de6332d9b1697a3eeeb6.tar.gz
dooly: Fix TCS3400 configuration
On dooly, TCS3400 has an interrupt line to the EC, so we don't need to simulate it. When we simulate and an interrupt line is present, 2 interrupts will be generated (one for a valid sample via GPIO, the other at preset timeout). When the timeout interrupt pops, there are no sample ready, so the EC will wait for a one for a long time and prevent other sensors data to be gathered. BUG=b:177860358 BRANCH=puff TEST=With an android AP pulling sensor data, check messages in /var/log/cros_ec.log like 0218/071812.170000 [45076.224405 tcs3400_post_events RGBC not valid (0x4)] 0218/071812.174000 [45076.228719 Screen Accel Missed 23 data collections at 2126184833 - rate: 16000] Are gone. Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Change-Id: I213ab02000a030572ed15e34b44a4761df615e2c (cherry picked from commit e5cb0b01129bceb70811156d1b1845796e493ebb) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2728697
Diffstat (limited to 'board/dooly')
-rw-r--r--board/dooly/board.h1
1 files changed, 0 insertions, 1 deletions
diff --git a/board/dooly/board.h b/board/dooly/board.h
index e2520d8fd7..75a0c2baa6 100644
--- a/board/dooly/board.h
+++ b/board/dooly/board.h
@@ -30,7 +30,6 @@
/* Sensor */
#define CONFIG_ACCEL_INTERRUPTS
-#define CONFIG_ALS_TCS3400_EMULATED_IRQ_EVENT
#define CONFIG_CMD_ACCEL_INFO
/* Enable sensor fifo, must also define the _SIZE and _THRES */
#define CONFIG_ACCEL_FIFO